Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333158 - StartupTracker waits by default 3600 seconds for every kernel bundle
Summary: StartupTracker waits by default 3600 seconds for every kernel bundle
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.0.0.M01   Edit
Assignee: Hristo Iliev CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 10:33 EST by Hristo Iliev CLA
Modified: 2011-02-01 11:00 EST (History)
2 users (show)

See Also:
hsiliev: review?


Attachments
Configurable wait limit for bundle&kernel start (9.00 KB, patch)
2011-01-13 10:19 EST, Hristo Iliev CLA
glyn.normington: review-
Details | Diff
Wait limit is configurable and for the whole kernel (13.51 KB, patch)
2011-01-14 02:48 EST, Hristo Iliev CLA
glyn.normington: review-
Details | Diff
Configurable start limit, removed "bundle did not start" message (13.40 KB, patch)
2011-01-14 06:23 EST, Hristo Iliev CLA
glyn.normington: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hristo Iliev CLA 2010-12-23 10:33:47 EST
StartupTracker has a default timeout of 3600 seconds for every bundle that is not started.

This makes the startup of Virgo in exceptional situations extremely slow.
Comment 1 Hristo Iliev CLA 2011-01-13 10:19:00 EST
Created attachment 186731 [details]
Configurable wait limit for bundle&kernel start
Comment 2 Glyn Normington CLA 2011-01-13 11:13:33 EST
Comment on attachment 186731 [details]
Configurable wait limit for bundle&kernel start

Hristo agrees that the new property should be for the whole kernel startup and not per bundle.
Comment 3 Hristo Iliev CLA 2011-01-14 02:48:57 EST
Created attachment 186804 [details]
Wait limit is configurable and for the whole kernel
Comment 4 Glyn Normington CLA 2011-01-14 04:22:50 EST
Comment on attachment 186804 [details]
Wait limit is configurable and for the whole kernel

The bundle error message is wrong. It can report "Bundle X did not start within 0 seconds". The fix Hristo and I have agreed is to remove the error message.
Comment 5 Hristo Iliev CLA 2011-01-14 06:23:26 EST
Created attachment 186816 [details]
Configurable start limit, removed "bundle did not start" message
Comment 6 Hristo Iliev CLA 2011-01-14 07:15:52 EST
Added configurable startup wait limit with commit
28f7df1e1cb214c46fd277964665477cba7e092e

The property that can be used to configure the commit is
org.eclipse.virgo.kernel.startup.wait.limit
Comment 7 Glyn Normington CLA 2011-01-14 07:18:19 EST
Please remember to do the doc change too.
Comment 8 Hristo Iliev CLA 2011-01-17 08:26:57 EST
Commit 0ac3b040a394d9924553ecb101dcfff9d8b00a39 adds documentation about kernel properties