Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333154 - Widget.isValidThread() should reuse the implementation of Display.isValidThread()
Summary: Widget.isValidThread() should reuse the implementation of Display.isValidThre...
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 1.4 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 09:42 EST by Florian Waibel CLA
Modified: 2010-12-28 10:29 EST (History)
1 user (show)

See Also:

Attachments
Patch containing the suggested reuse of Display.isValidThread (1.00 KB, patch)
2010-12-23 09:44 EST, Florian Waibel CLA 		rsternberg: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Waibel CLA 2010-12-23 09:42:37 EST 
The Widget class could delegate isValidThread to the Display class instead of implementing the compare operation itself.
Comment 1 Florian Waibel CLA 2010-12-23 09:44:55 EST 
Created attachment 185771 [details]
Patch containing the suggested reuse of Display.isValidThread
Comment 2 Ralf Sternberg CLA 2010-12-28 10:26:51 EST 
This patch looks good to me. It is a verbatim copy of the SWT code and also saves the acquisition of the deviceLock in Display#getThread() which apparently is unnecessary in this case.
Applied patch to CVS.