Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333103 - [tests] Failures in nightly build
Summary: [tests] Failures in nightly build
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-22 11:20 EST by DJ Houghton CLA
Modified: 2010-12-23 13:12 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-12-22 11:20:36 EST 
There is a test failure in the nightly build. This is happening after the 2nd patch for bug 332655. The test is expecting an IllegalArgumentException but not getting it anymore. Pascal, I believe this is an incorrect assumption in the test but wanted to confirm with you before making changes. 

junit.framework.AssertionFailedError: null
at org.eclipse.equinox.p2.tests.engine.EngineTest.testIncompatibleProfile(EngineTest.java:800)
at org.eclipse.equinox.p2.tests.AbstractProvisioningTest.runTest(AbstractProvisioningTest.java:920)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 1 Pascal Rapicault CLA 2010-12-22 11:47:12 EST 
The test needs to be changed to have an operand so that we continue testing the case of the illegal argument exception. In fact, we should also probably improve the test to check for the message in the exception as other places in the code throw this exception.
Comment 2 DJ Houghton CLA 2010-12-23 13:12:54 EST 
Released change in HEAD to add operand to plan.