Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333025 - Allow additional JVM arguments through ICustomAnalysisProvider extension point
Summary: Allow additional JVM arguments through ICustomAnalysisProvider extension point
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Joel Cayne CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 10:49 EST by Joel Cayne CLA
Modified: 2016-05-05 11:20 EDT (History)
2 users (show)

See Also:
mikereid: review+

Attachments
Patch for additional JVM arguments (5.51 KB, patch)
2010-12-21 10:50 EST, Joel Cayne CLA 		no flags Details | Diff
Patch for additional JVM arguments (5.58 KB, patch)
2010-12-21 13:17 EST, Joel Cayne CLA 		no flags Details | Diff
Patch to use a list for ProcessParameters (7.44 KB, patch)
2010-12-22 17:25 EST, Joel Cayne CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2010-12-21 10:49:25 EST 
The ICustomAnalysisProvider extension point allows for additional JVMTI arguments to be passed to a launch command. It could be updated to allow for additional JVM arguments to be appended to the launch command.
Comment 1 Joel Cayne CLA 2010-12-21 10:50:41 EST 
Created attachment 185643 [details]
Patch for additional JVM arguments
Comment 2 Joel Cayne CLA 2010-12-21 13:17:34 EST 
Created attachment 185656 [details]
Patch for additional JVM arguments

Updated to exclude empty Strings for JVM arguments.
Comment 3 Joel Cayne CLA 2010-12-21 13:32:18 EST 
Mike,
Can you please review the patch?

Thanks!
Comment 4 Mike Reid CLA 2010-12-21 13:44:50 EST 
Patch looks good.
Comment 5 Kathy Chan CLA 2010-12-21 13:58:00 EST 
Approved for 4.7.2.
Comment 6 Joel Cayne CLA 2010-12-21 17:22:45 EST 
Patch checked into HEAD with project lead approval.

I added that quotes should be included around the JVM arguments if there is a space to the comment for the new method in ICustomAnalysisProvider.
Comment 7 Joel Cayne CLA 2010-12-22 17:24:48 EST 
Re-opening to update getVMArg to use a List for the extra JVM arguments.
Comment 8 Joel Cayne CLA 2010-12-22 17:25:39 EST 
Created attachment 185740 [details]
Patch to use a list for ProcessParameters
Comment 9 Mike Reid CLA 2010-12-23 11:20:47 EST 
New patch using List<String> looks good.
Comment 10 Jonathan West CLA 2010-12-23 11:23:09 EST 
Updated patch approved for 4.7.2.
Comment 11 Joel Cayne CLA 2010-12-23 14:51:47 EST 
Patch checked into HEAD.
Comment 12 Joel Cayne CLA 2011-01-17 09:26:23 EST 
Closing.