Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 333009 - non-Eclipse repositories ending up referenced in SimRel common repositories
Summary: non-Eclipse repositories ending up referenced in SimRel common repositories
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Cross-Project (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 08:00 EST by David Williams CLA
Modified: 2012-06-06 12:58 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-12-21 08:00:43 EST
There a couple of non-Eclipse software repositories that end up in the list of repositories in common repo, for M4. You can see these in the content.xml file produced for /releases/indigo/201012170900. (There is, in total, 94 such references generated ... which doesn't seem good ... but ... but, the two this bug is about are

     http://lwjgl.org
     http://metascapeabm.com

I'm not sure where these come from, but will make the following observations: 

A. This isn't "allowed". The common repo is only for eclipse projects. I've not heard of any exceptions that are required, so suspect these are mistakes of one type or another. 

B. I have heard about one of them, 'lwjgl.org' mentioned on cross-project list about build-time-only requirements for Amp. So, one possible problem is a build-time-only feature from AMP is making its way into the main repository, instead of being used only at build-time. 

C. As part of its aggregation, the b3 aggregator does go through all the contributed features and extract all the referenced "update sites" mentioned in feature.xml's and, well, aggregates them, in the content.jar/xml file for "ease of use" by end-users. There are mechanisms to exclude some sites, by name, but ... seems these "external" sites should not be in ordinarily installed features anyway, so I think the first step is finding where these are being "contributed" and fixing the original features.
Comment 1 David Williams CLA 2010-12-21 08:02:06 EST
Miles, I assume the lwigl.org one is "yours" ... do you (or anyone else) know where the 'metascapeabm' one comes from?
Comment 2 Miles Parker CLA 2010-12-21 15:54:45 EST
(In reply to comment #0)
>      http://lwjgl.org
>      http://metascapeabm.com

These ere mine. The second is completely dross, the first is more complicated...

> I'm not sure where these come from, but will make the following observations: 
> 
> A. I've not heard of any exceptions that are required, so suspect these are mistakes of one
> type or another. ... So, one possible problem is a
> build-time-only feature from AMP is making its way into the main repository,
> instead of being used only at build-time. 

Yes, I was definitely aware of these issues, see:

http://git.eclipse.org/c/amp/org.eclipse.amp.git/tree/releng/org.eclipse.amp.releng/releng/amp.rmap


"<!-- NOTE: ***Not for inclusion in Eclipse provided builds. Provides support for externally hosted plugin dependencies.*** -->"

> 
> C. As part of its aggregation, the b3 aggregator does go through all the
> contributed features and extract all the referenced "update sites" mentioned in
> feature.xml's and, well, aggregates them, in the content.jar/xml file for "ease
> of use" by end-users. There are mechanisms to exclude some sites, by name, but
> ... seems these "external" sites should not be in ordinarily installed features
> anyway, so I think the first step is finding where these are being
> "contributed" and fixing the original features.

Yes, the inclusion was unintentional. I was not aware that aggregator includes referenced update sites. That's a bit confusing since it includes them, but then fails to resolve against them which seems the worst of both worlds.. :P It's a bit of a bummer, because it means that people installing the plugins even from another source will have to manually add the update site, but in practice that is probably what most people do anyway.

I brought the general issue up on Modeling PMC, see:

http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01923.html
http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01925.html
http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01926.html

I'm between a rock and a hard place, because without the 3D support a lot of the functionality is missing, but there aren't any OpenGL libraries that meet Eclipse standards.

 But what I'm *really* puzzled by is why this showed up in b3 now -- I don't include any of this stuff in the current build! So how is B3 aggregator somehow including a larger set of features than are specified for build target?

I'm going to look at the required features and see where they're defined.
Comment 3 Miles Parker CLA 2010-12-22 22:01:49 EST
I've removed the two sites mentioned from the url discovery element.
Comment 4 David Williams CLA 2012-06-06 02:27:36 EDT
seems fixed long ago (and for Juno, we do not include referenced repos ... though still true no feature should reference 'external' site.
Comment 5 Miles Parker CLA 2012-06-06 12:58:49 EDT
Yes, I did fix it last year. Note now that Wayne is reposting that gef3d is showing up on the aggregated repos. I can't figure out how that would have got there unless the aggregator is pulling stuff from the aggregated site that it hasn't been asked for...