Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332926 - Editing SMILA pipelines in BPEL Designer
Summary: Editing SMILA pipelines in BPEL Designer
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Smila (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Igor Novakovic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 04:12 EST by Tobias Liefke CLA
Modified: 2022-07-07 11:31 EDT (History)
4 users (show)

See Also:


Attachments
BPEL Designer extensions - First shot (117.52 KB, application/octet-stream)
2010-12-20 04:26 EST, Tobias Liefke CLA
no flags Details
BPEL Designer extensions - Bug fixes (117.69 KB, application/octet-stream)
2011-01-13 11:12 EST, Tobias Liefke CLA
no flags Details
BPEL Designer extensions - Fixed javax.wsdl version reference (118.02 KB, application/octet-stream)
2011-01-14 04:14 EST, Tobias Liefke CLA
no flags Details
updated extension plugins (235.99 KB, application/octet-stream)
2011-01-14 16:51 EST, Robert Brodt CLA
no flags Details
BPEL Designer extensions - Fixed source/design sync (118.03 KB, application/octet-stream)
2011-01-17 06:19 EST, Tobias Liefke CLA
no flags Details
BPEL Designer extensions (117.47 KB, application/octet-stream)
2011-02-02 12:04 EST, Tobias Liefke CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Liefke CLA 2010-12-20 04:12:36 EST
Build Identifier: 

The BPEL Designer (http://www.eclipse.org/bpel/) is an eclipse project that lets the user edit WS-BPEL 2.0 processes. 

This task adds support for SMILA specific enhancements (pipelets, services, ...) to the BPEL Designer.

Reproducible: Always
Comment 1 Tobias Liefke CLA 2010-12-20 04:26:15 EST
Created attachment 185519 [details]
BPEL Designer extensions - First shot

The first shot to extend the BPEL designer with support for pipelets and services.
Up to now its more a "proof of concept".

What works:
* Opening SMILA pipelines and examining pipelets and services
* Editing pipelet type, pipelet poperties, service name and service annotations

What is missing:
* Synchronizing of changes to pipelets/services between "Source" tab and "Design" tab
* Direct editing of the annotations in the tree
Comment 2 Igor Novakovic CLA 2011-01-07 10:47:25 EST
First I'd like to thank you for this cool contribution!

While testing I encountered some of the bugs:
1. When dragging/adding an SMILA Pipelet in GUI in some workflow a new extension activity is created in the source. The problem is that setting the class attribute (vie description/type in property editor) of the "proc:pipelet" tag does not work. Also the "proc:variables" tag does not get input and output attributes set to "request".
2. Adding annotations to a newly added service (by dragging the icon from the palette) does not work at all
3. Setting the Servicename in the property editor (in tab "Description") is persited only in the editor itself but not in the BPEL source file.

It would be great if you could fix some of this issues!

Cheers
Igor
Comment 3 Tobias Liefke CLA 2011-01-13 11:12:09 EST
Created attachment 186741 [details]
BPEL Designer extensions - Bug fixes

I fixed the bugs (1) and (3) mentioned above.

The requested feature in (2) is not implemented up to now, as described in my first comment. I hope it will follow soon...

Synchronization from [Design] view to [Source] view works now, but I have no idea how to implement the synchronization from [Source] view to [Design] view. Maybe someone from the BPEL Designer team can help...
Comment 4 Robert Brodt CLA 2011-01-13 17:20:21 EST
Hi Tobias, I'm assuming the source for these extensions exists only in the attachment (not in CVS)? I've downloaded the two plugins and am trying to get these to run with the current BPEL designer, but I'm running into some plugin Activator problems - I'll let you know if I need help getting started.
Comment 5 Igor Novakovic CLA 2011-01-14 03:46:55 EST
Hi Bob,

I guess the problems that you have are the same that I had and wrote about them and the solution in our dev mailing list.
Did you try to change in MANIFEST.MF of org.eclipse.smila.processing.designer.model from

javax.wsdl;bundle-version="1.5.1",

to 

javax.wsdl;bundle-version="[1.5.1,1.6.0)",

and then run it?
Comment 6 Tobias Liefke CLA 2011-01-14 04:14:50 EST
Created attachment 186806 [details]
BPEL Designer extensions - Fixed javax.wsdl version reference

I fixed that now in the new attachment. 

By the way, that wrong version reference is already in the org.eclipse.bpel.extensionsample.model project (that we used as template for our project). I will create a BPEL Designer bug report for that.

p.s. @Bob: The extensions are not in the repository up to now, I think Igor will add them as soon as we fix the synchronization problem.
Comment 7 Igor Novakovic CLA 2011-01-14 04:27:45 EST
> p.s. @Bob: The extensions are not in the repository up to now, I think Igor will add them as soon as we fix the synchronization problem.
Yep. I can confirm that.
As soon as Tobias' extensions are working fine we will check them into SMILA's repository and maintain them there.
Comment 8 Igor Novakovic CLA 2011-01-14 06:04:16 EST
@Tobias:
I've tested all your fixes and can confirm that issues (1) and (3) are fixed now.
That is great!
Thanks
Comment 9 Robert Brodt CLA 2011-01-14 07:38:33 EST
(In reply to comment #7)
> > p.s. @Bob: The extensions are not in the repository up to now, I think Igor will add them as soon as we fix the synchronization problem.
> Yep. I can confirm that.
> As soon as Tobias' extensions are working fine we will check them into SMILA's
> repository and maintain them there.

Cool, sounds like a plan
Hopefully I can fix the sync problem with extensionActivities today...

BTW, Tobias: I think the calls to ReconciliationHelper.replaceAttribute() in VariablesImpl to set the "input" and "output" attributes should be:

ReconciliationHelper.replaceAttribute(this, ProcessorConstants.ATT_INPUT, newInput);

and

ReconciliationHelper.replaceAttribute(this, ProcessorConstants.ATT_OUTPUT, newOutput);
Comment 10 Tobias Liefke CLA 2011-01-14 09:11:19 EST
You are right Bob, seems that we just used the "auto suggestions" of eclipse there (and didn't noticed as you can't change the variables in our GUI up to now). I will fix that in the next commit.
Comment 11 Robert Brodt CLA 2011-01-14 16:49:20 EST
Hi all,

I have fixed the extension activity synchronization problem and checked in to CVS at eclipse.org. I found that I had to change the signature for the extension activity deserializer (it needs to use the Activity that was created originally by the factory method), so I updated the SMILA designer plugins and attached them to this bugzilla.

Tobias, let me know if this works or if you need additional help finishing this up.
Comment 12 Robert Brodt CLA 2011-01-14 16:51:11 EST
Created attachment 186853 [details]
updated extension plugins
Comment 13 Tobias Liefke CLA 2011-01-17 06:19:48 EST
Created attachment 186897 [details]
BPEL Designer extensions - Fixed source/design sync

Your fix brought up a new problem: Every change increased the count of pipelet properties. As a solution I clear that list before filling it again.

As this is working now, I think Igor can add the extensions to the repository. 
I know that there are some issues left, like editing the annotations tree, but that may take some time and I will address that later.
Comment 14 Igor Novakovic CLA 2011-01-18 08:02:14 EST
Thank you Tobias and Bob!

Now the extension is good enough to work with, so we can check it in our repository.

@Jurgen & Andreas:
Can you please check in the extensions direct under our "trunk" in SVN?

BTW: I will "polish" all of our sample workflows next week when I am back from my vacation.
Comment 15 Juergen Schumacher CLA 2011-01-18 09:37:25 EST
I've added the two bundles to our trunk (adapted src/bin paths to SMILA standard) and added a note about not adding them to the workspace to http://wiki.eclipse.org/SMILA/Development_Guidelines/Howto_set_up_dev_environment. We will extend the environment descriptions and build scripts later, such that they can be compiled and are added to the binary build.
Comment 16 Tobias Liefke CLA 2011-02-02 12:04:49 EST
Created attachment 188167 [details]
BPEL Designer extensions

We added some improvements to our extensions:
* generated XML source is beautified
* improved handling of changes in the XML view
* inline editing in the service annotations tree
* select box for the pipelet class (contains all known classes of SMILA pipelets, up to now hardcoded)
Comment 17 Igor Novakovic CLA 2011-02-02 12:27:18 EST
Cool!
Thank you for the update Tobias!

@Jürgen:
Could you please check in the changes into our repository?

Cheers
Igor
Comment 18 Juergen Schumacher CLA 2011-02-03 03:16:56 EST
Done. Without having checked anything.
@Tobias: Would it be possible to do further changes based on the current SVN version? I've changed the bundle structure a bit so that it conforms to the other SMILA bundles. 
Also, a short description in the Wiki on how to extend the SMILA workspace setup such that these bundles compile would be nice. Then I could check at least if I merged your changes correctly before checking them in (-:
Comment 19 Tobias Liefke CLA 2011-03-31 08:56:18 EDT
I just checked in the new version of the plugins that are now adapted to the new pipelet configuration. 

It was tested against Eclipse 3.6.2 and BPEL Designer 0.5 H60 (2011-03-29_21-34-07-H60).

The install description was updated, too: http://wiki.eclipse.org/SMILA/BPEL_Designer.
Comment 20 Tobias Liefke CLA 2011-11-23 02:55:22 EST
The UI now allows to enter the variables, including the new index variable.
Comment 21 Tobias Liefke CLA 2012-04-18 11:09:10 EDT
Closed, as the initial cause for the request was integrated long ago.