Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332919 - Syntax Coloring - 'Static fields' doesn't work well
Summary: Syntax Coloring - 'Static fields' doesn't work well
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 minor (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact: Ilina Stefanova CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 02:07 EST by Toshihiro Izumi CLA
Modified: 2020-05-14 11:08 EDT (History)
1 user (show)

See Also:


Attachments
patch for preference page (1.84 KB, patch)
2010-12-29 19:52 EST, Toshihiro Izumi CLA
no flags Details | Diff
patch for editor (2.06 KB, patch)
2010-12-29 19:52 EST, Toshihiro Izumi CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toshihiro Izumi CLA 2010-12-20 02:07:19 EST
Steps to reproduce:
1. Open Preferences>PHP>Editor>Syntax Coloring
2. Select 'Static fields' (it is enabled and 'Italic' is checked by default)
3. Click 'Bold' for example
=> Sample text won't be changed, '$my_static' should be displayed in italic and bold
4. Click '$my_static' in sample text
=> 'Fields' in elements list will be selected, 'Static fields' should be selected

In PHP Editor, 'Static fields' coloring doesn't work in declaration but works in statement.
class Foo {
	public static $sta=0; // colored according to 'Fields' setting
}
Foo::$sta; // colored according to 'Static fields' setting
Comment 1 Toshihiro Izumi CLA 2010-12-29 19:52:24 EST
Created attachment 185893 [details]
patch for preference page
Comment 2 Toshihiro Izumi CLA 2010-12-29 19:52:52 EST
Created attachment 185894 [details]
patch for editor
Comment 3 Zhongwei Zhao CLA 2011-04-19 00:59:15 EDT
great,it is ok for me,applied to head,thanks!
Comment 4 Ilina Stefanova CLA 2011-07-26 03:13:54 EDT
Verified.