Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332754 - [Help] Problems in help tray with focus in main dialog area
Summary: [Help] Problems in help tray with focus in main dialog area
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 127852
Blocks:
  Show dependency tree
 
Reported: 2010-12-16 11:03 EST by Markus Keller CLA
Modified: 2011-01-05 17:06 EST (History)
0 users

See Also:

Attachments
Patch (2.20 KB, patch)
2011-01-05 17:05 EST, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-12-16 11:03:09 EST 
Follow-up to bug 127852

- org.eclipse.help.ui.internal.views.ContextHelpPart#updateTitle(Control) calls
#computeSearchTerms(Control), which always starts looking for a title in the
the parent of the passed control. When the dialog shell has focus, the code
misses the obvious target. After bug 127852 is fixed, the scenario from
bug 127852 comment 12 cannot be reproduced any more, but the problem should be fixed anyway.

- org.eclipse.help.ui.internal.views.HelpTray.createActions()... calls "shell.setFocus();" (on line line 85).
That was a workaround for a bug in TrayDialog#closeTray(), see
bug 127852 comment 12. This line should be removed now that bug 127852 has been fixed.
Comment 1 Chris Goldthorpe CLA 2011-01-05 17:05:08 EST 
Created attachment 186133 [details]
Patch

I agree with the suggestions, this patch implements both.
Comment 2 Chris Goldthorpe CLA 2011-01-05 17:06:28 EST 
Patch committed to HEAD. Fixed.