Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332734 - tooltips missing in Task Editor
Summary: tooltips missing in Task Editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 major (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-16 08:31 EST by Ralf Sternberg CLA
Modified: 2011-02-02 00:57 EST (History)
3 users (show)

See Also:


Attachments
mylyn/context/zip (12.17 KB, application/octet-stream)
2010-12-21 17:02 EST, Frank Becker CLA
no flags Details
commited patch (935 bytes, patch)
2010-12-21 17:50 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (20.91 KB, application/octet-stream)
2010-12-21 17:50 EST, Frank Becker CLA
no flags Details
patch V2 (2.12 KB, patch)
2010-12-23 15:49 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (8.74 KB, application/octet-stream)
2010-12-23 15:49 EST, Frank Becker CLA
no flags Details
backwards compatible approach using delegate (8.43 KB, patch)
2011-02-02 00:55 EST, Steffen Pingel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2010-12-16 08:31:05 EST
With latest Mylyn 3.5.0, I20101110, 13:00, no tooltips are displayed on referenced bugs in comments and depends/blocks fields anymore :(
Comment 1 Steffen Pingel CLA 2010-12-16 10:59:37 EST
Args. That is probably a regression from bug 331154. We'll look into it.
Comment 2 Frank Becker CLA 2010-12-21 17:02:17 EST
(In reply to comment #1)
> Args. That is probably a regression from bug 331154. We'll look into it.

No, I found that this is a problem with eclipse 3.7M4 if I use 3.6.1 there is no problem.

It looks like that are some changes with the way showing tooltips for hyperlinks that force this error. Even if I remove in RichTextAttributeEditor.createControl the call of editor.getViewer().getTextWidget().setToolTipText(getDescription()); the error is there.

Steffen should I continue to find a fix?
Comment 3 Frank Becker CLA 2010-12-21 17:02:20 EST
Created attachment 185674 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2010-12-21 17:31:11 EST
Hmm, I see a tooltip in various places in the editor that says "Tooltip Defaul Text" even on 3.6. Not sure if that's the same problem or if it's another bug. 

Can you reproduce the lack of tooltips in a small code snippet? Could be worth filing against SWT.
Comment 5 Frank Becker CLA 2010-12-21 17:50:22 EST
Created attachment 185680 [details]
commited patch

(In reply to comment #4)
> Hmm, I see a tooltip in various places in the editor that says "Tooltip Defaul
> Text" even on 3.6. Not sure if that's the same problem or if it's another bug. 
> 
> Can you reproduce the lack of tooltips in a small code snippet? Could be worth
> filing against SWT.

Sorry I did not disable an test statement.

Need some work to isolate the problem.

I start to tomorrow!
Comment 6 Frank Becker CLA 2010-12-21 17:50:24 EST
Created attachment 185681 [details]
mylyn/context/zip
Comment 7 Frank Becker CLA 2010-12-23 15:49:12 EST
Created attachment 185790 [details]
patch V2

Steffen,

I found the problem but I need some help to implement a fix.

MultipleHyperlinkPresenter.showHyperlinks(IHyperlink[] activeHyperlinks, boolean takesFocusWhenVisible) is an new method in 3.7 that replace MultipleHyperlinkPresenter.showHyperlinks(IHyperlink[] activeHyperlinks).

This patch is for >= 3.7M4 but how we get this for older versions
Comment 8 Frank Becker CLA 2010-12-23 15:49:14 EST
Created attachment 185791 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2011-02-02 00:55:53 EST
Created attachment 188115 [details]
backwards compatible approach using delegate
Comment 10 Steffen Pingel CLA 2011-02-02 00:57:55 EST
Thanks for investigation this Frank! Unfortunately there is no straight forward approach to make this work in a backwards compatible way that compiles and works on Eclipse 3.4 - 3.6. I have committed the attached patch which uses a delegate and invokes the new API methods through reflection.