Comment 1 Sebastian Benz 2010-12-15 09:35:59 EST

I accidentally added an empty test case (XBinaryOperationTest) to the patch, which can be safely ignored.

Comment 2 Sebastian Benz 2010-12-15 10:08:55 EST

Created attachment 185228 [details]
Bug fix & tests

Comment 3 Sebastian Benz 2010-12-15 11:16:33 EST

Created attachment 185237 [details]
Updated bug fix & test

Comment 4 Sebastian Zarnekow 2011-01-04 04:49:38 EST

Patch has been applied. Thanks.

Comment 5 Sven Efftinge 2011-01-19 12:35:16 EST

getArguments is now called getAllArguments and is no longer an EReference but an EOperation.

I wonder whether we should exclude 'derived' and 'transient' cross references in 
LazyLinkingResource.resolveLazyCrossReference(InternalEObject, EStructuralFeature)

An comments?

Comment 6 Sebastian Zarnekow 2011-01-19 12:42:34 EST

(In reply to comment #5)
> I wonder whether we should exclude 'derived' and 'transient' cross references
> in 
> LazyLinkingResource.resolveLazyCrossReference(InternalEObject,
> EStructuralFeature)
> 
> An comments?

I think it should behave like the EObjectValidator when it tries to detect unresolved proxies.

Comment 7 Knut Wannheden 2011-01-19 13:55:08 EST

(In reply to comment #6)
> (In reply to comment #5)
> > I wonder whether we should exclude 'derived' and 'transient' cross references
> > in 
> > LazyLinkingResource.resolveLazyCrossReference(InternalEObject,
> > EStructuralFeature)
> > 
> > An comments?
> 
> I think it should behave like the EObjectValidator when it tries to detect
> unresolved proxies.

I agree. In our projects we've used both transient and derived references which we normally want to be checked by the validation.

Comment 8 Sven Efftinge 2011-01-20 00:17:36 EST

> 
> I agree. In our projects we've used both transient and derived references which
> we normally want to be checked by the validation.

But derived or transient features do not contain lazy proxies, do they?

Comment 9 Knut Wannheden 2011-01-20 01:04:23 EST

(In reply to comment #8)
> > 
> > I agree. In our projects we've used both transient and derived references which
> > we normally want to be checked by the validation.
> 
> But derived or transient features do not contain lazy proxies, do they?

In our case they actually sometimes do. In these cases the linker will in afterModelLinked() have installed a lazy proxy based on the node model for another EAttribute. We then dub this a "derived attribute based reference".

One use case for this is languages like Ada with separate package specification and body files, where the package body name should also be an implicit reference to its package specification. Parsing this as a cross reference in the first place is not so good as this may cause problems for the builder when computing the corresponding EObjectDescription's name (or would alternatively require extracting the name from the node model). 

Of course subsequent (i.e. post parse) changes to the EAttribute must be tracked by an EAdapter, at which point the EReference no longer has a lazy proxy.

Comment 10 Karsten Thoms 2017-09-19 17:02:57 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 11 Karsten Thoms 2017-09-19 17:14:30 EDT

Closing all bugs that were set to RESOLVED before Neon.0