Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332614 - buckminster.build.id property not inserted into p2 metadata
Summary: buckminster.build.id property not inserted into p2 metadata
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 06:24 EST by Michal Ruzicka CLA
Modified: 2019-02-25 14:41 EST (History)
1 user (show)

See Also:

Attachments
org.eclipse.buckminster.pde-follow_upstream_change.patch (2.20 KB, patch)
2010-12-15 07:10 EST, Michal Ruzicka CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ruzicka CLA 2010-12-15 06:24:04 EST 
Buckminster used to insert buckminster.build.id property into p2 metadata it generated for bundles which contained about.mappings files referencing the build id by means of the @build@ placeholder.
Recent Buckminster does not do that any more.

The problem seems to be caused by a change in p2 API - the following function is apparently deprecated (and no longer called):

	//TODO remove this method
	protected void org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.generateBundleIUs(BundleDescription[] bundleDescriptions, IPublisherResult result, IProgressMonitor monitor) {
		generateBundleIUs(bundleDescriptions, null, result, monitor);
	}

And since it is this function which is overridden in Buckminster (by org.eclipse.buckminster.pde.tasks.BundlesAction.generateBundleIUs)
to add the buckminster.build.id p2 publishing property advice it is obvious why the property is not being added any more.
Comment 1 Michal Ruzicka CLA 2010-12-15 07:10:14 EST 
Created attachment 185218 [details]
org.eclipse.buckminster.pde-follow_upstream_change.patch

The attached patch fixes to issue simply by overriding the method which replaced the deprecated one.
Comment 2 Michal Ruzicka CLA 2010-12-15 07:37:10 EST 
the patch was committed in revision 11623, to the helios-maintenance branch of the project