Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332498 - Regression: Cannot maximize views any more
Summary: Regression: Cannot maximize views any more
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 04:34 EST by Martin Oberhuber CLA
Modified: 2011-03-17 16:21 EDT (History)
3 users (show)

See Also:

Attachments
Extend the MinMaxAddon to allow both min and max everywhere (36.97 KB, patch)
2011-03-02 16:17 EST, Eric Moffatt CLA 		no flags Details | Diff
Updated version of previous patch fixing Remy's issues (37.64 KB, patch)
2011-03-03 16:06 EST, Eric Moffatt CLA 		no flags Details | Diff
Updated patch fixing known issues (45.44 KB, patch)
2011-03-17 14:17 EDT, Eric Moffatt CLA 		no flags Details | Diff
WorkbenchPage patch v1 (1.64 KB, patch)
2011-03-17 16:20 EDT, Remy Suen CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-12-14 04:34:10 EST 
Build ID: 4.1 SDK M4

I cannot maximize any views any more by dbl clicking their caption. Only maximizing the editor area still works. This is a big problem for me, since I'm very used to temporarily maximizing a view to see its full contents.

I'm pretty sure that this still worked with M3 so it seems to be a regression.

1. Help > Search
2. Click on "Show Web Results" link
3. Try to maximize the Help View by dbl clicking its caption --> fails
Comment 1 Remy Suen CLA 2010-12-15 17:04:23 EST 
(In reply to comment #0)
> I'm pretty sure that this still worked with M3 so it seems to be a regression.

On the contrary, I'm pretty sure it never worked. :O
Comment 2 Praveen CLA 2011-02-25 02:07:53 EST 
I am hit with the same problem. I need to maximize the Console view by double clicking the title area to see the full contents of logged errors. It used to work with Eclipse 3.x, but never worked with Eclipse 4.
Comment 3 Eric Moffatt CLA 2011-03-02 16:17:23 EST 
Created attachment 190203 [details]
Extend the MinMaxAddon to allow both min and max everywhere


This handles all the mouse-oriented handling, including double click.

'WorkbenchPage#toggleZoom()' (aka Ctrl-M) still only works against the editor area...
Comment 4 Remy Suen CLA 2011-03-03 08:22:42 EST 
1. Maximize the stack with the 'Outline' in it.
2. Restore the stack with the 'Package Explorer' view in it.
3. Maximize the stack with the 'Package Explorer' view.
4. Restore/unmaximize stack B the stack with the 'Package Explorer' view.
5. The stack with the 'Outline' in it.

1. Maximize the stack with the 'Package Explorer' in it.
2. Ctrl+M.
3. Eclipse shuts itself down.

1. Maximize the stack with the 'Package Explorer' in it.
2. Restore the stack with the 'Outline' view in it.
3. It goes into overlay mode instead.

1. Maximize the stack with the 'Package Explorer' in it.
2. Click the icon for the 'Outline' view in it in the trim.
3. Try to restore it now.
4. It will now move from the right to the left side. It is still in overlay mode at this point.
5. Try to maximize it.
6. Eclipse shuts itself down.
Comment 5 Eric Moffatt CLA 2011-03-03 10:56:23 EST 
Note that there's still an issue with resetting a perspective containing a minimized or maximized shared area; the MArea's CTF buttons are not being reset.

I'll check on Remy's results now...
Comment 6 Eric Moffatt CLA 2011-03-03 16:06:01 EST 
Created attachment 190311 [details]
Updated version of previous patch fixing Remy's issues


There are still some minor issues with the various CTF min/max buttons being left in the wrong state...
Comment 7 Remy Suen CLA 2011-03-03 16:31:13 EST 
1. Minimize the shared area.
2. Switch to the 'Debug' perspective.
3. Maximize the shared area.
4. Switch back to the 'Java' perspective.
5. The trim on the right is cut.
Comment 8 Eric Moffatt CLA 2011-03-17 14:17:01 EDT 
Created attachment 191452 [details]
Updated patch fixing known issues


The only remaining issue that I can see is when switching between maximized parts:

- in the Java Perspective
- maximize the editor area
- restore the Package Explorer
- Maximize the PE

You get the same chopped off trim we used to get on a perspective switch
Comment 9 Eric Moffatt CLA 2011-03-17 14:18:07 EDT 
Committed in >20110317. Applied the patch.
Comment 10 Eric Moffatt CLA 2011-03-17 14:20:58 EDT 
Added bug 340358 to track the trim layout issue.
Comment 11 Remy Suen CLA 2011-03-17 16:20:09 EDT 
Created attachment 191467 [details]
WorkbenchPage patch v1

Patch to get Ctrl+M to work as this feature is of little use to me if the keybinding still only acts on the shared area.
Comment 12 Remy Suen CLA 2011-03-17 16:21:12 EDT 
(In reply to comment #11)
> Created attachment 191467 [details]
> WorkbenchPage patch v1

Patch released to CVS HEAD.