Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332489 - [quick assist] 'exchange left and right operands' for comparison operators changes semantics
Summary: [quick assist] 'exchange left and right operands' for comparison operators ch...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 22:44 EST by Deepak Azad CLA
Modified: 2010-12-14 05:03 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2010-12-13 22:44:11 EST 
Fix for Bug 149803 was not good.

The right fix should do the following
  if(a > b)  --> if(b < a)
  if(a >= b) --> if(b <= a)
  if(a < b)  --> if(b > a)
  if(a <= b) --> if(b >= a)
Comment 1 Deepak Azad CLA 2010-12-13 22:59:27 EST 
Fixed in HEAD in AdvancedQuickAssistProcessor.
Comment 2 Dani Megert CLA 2010-12-14 03:18:37 EST 
Please add some tests.
Comment 3 Deepak Azad CLA 2010-12-14 05:03:43 EST 
Yeah, I had updated the tests in AdvancedQuickAssistTest.