Community
Participate
Working Groups
There are use cases where additional controls are needed, but placing them in the advanced section seems weird. One example if a domain needs to be set as part of the credentials. I am proposing a "createMoreSettingsControls" (or similarily named) to add more controls below the password controls.
Can't create a patch as there is no pserver access yet, but I would simply add something like the following in line 505 of AbstractRepositorySettingsPage: (not too sure on how to best deal with the 3 column layout here) bc.. Composite moreControlsContainer = new Composite(compositeContainer, SWT.NONE); GridLayoutFactory.swtDefaults().applyTo(moreControlsContainer); GridDataFactory.swtDefaults().span(3, SWT.DEFAULT).applyTo(moreControlsContainer); createMoreSettingsControls(moreControlsContainer); p. plus bc.. /** * Overwrite to add additional controls to the main composite above the expandable sections */ protected void createMoreSettingsControls(Composite parent) { // ignore }
Can you give a concrete example what type of controls you would like to add? The page is designed around extensibility through sections which provides some consistency accross connectors.
As mentioned in the description, setting a domain (as part of the credentials) is a use case I ran into. Putting the domain field in the advanced section or in a separate section seems weird, as it is part of the credentials. We could also solve this by adding a domain field and requiring a setNeedsDomain(true) to make it show up. This would limit the ability of connectors to mess up a common UI design.
Thanks. That's an interesting use case. Not sure how we can best address that. Let's discuss on an upcoming Mylyn call.
Shawn, do you have any input on this?
I am unsure if this is needed or not. I have done something similar before by overriding createSettingControls, but this only allows you to add items above the Server field or below the password. It would be nice sometimes to have the ability to add something before the credentials area or after the server.
In order to pursue this further we would need a patch. If this can be resolved with the current API I am inclined to mark this as wontfix since the proposed API would make it difficult to change to the layout of the setting page in the future.
An alternative would be to include a (by default deactivated) domain field, with a "setNeedsDomain" method. And add more if we see the need
I have only heard of one connector requiring a Domain setting so I don't think it's worth adding to the common schema at this point. I'll mark this bug as wontfix as per comment#7. Please feel free to reopen if the need to add additional controls arises again and we can reconsider.
