Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332476 - add project in deployment Assembly - does not work
Summary: add project in deployment Assembly - does not work
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Rob Stryker CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 16:46 EST by juny CLA
Modified: 2011-08-22 02:39 EDT (History)
2 users (show)

See Also:
cbridgha: review+

Attachments
Make the WebModuleDependencyPageProvider apply to wst.web projects also (1008 bytes, patch)
2011-07-05 08:54 EDT, Rob Stryker CLA 		no flags Details | Diff
patch v2 to also ensure the property page closes properly (4.21 KB, patch)
2011-07-05 12:38 EDT, Rob Stryker CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description juny CLA 2010-12-13 16:46:26 EST 
Build Identifier: 20100617-1415

add project in deployment Assembly finished with no error. But when web project properties, select deployemnt assembly, the added project is not on the list at all.

Reproducible: Always

Steps to Reproduce:
1.create a simple web project.
2.create a simple java project.
3.right click on the web project, select properties
4.select deployment Assembly, click add button
5.select project from new Assebly directive popup window then next button, pick the java project you created on the step 2. then click finish button. Then you will see java project jar file was placed under deploy path (WEB-INF/lib/**.jar) in the list.
6. click apply button, then ok to close properties for your web project.
7. right click your web project, then select properties again, select deployement assembly again, the project you just added was not on the deploy path any more.
Comment 1 juny CLA 2010-12-13 16:48:09 EST 
the project was created from other version of eclipse could be added into deployment assembly.
Comment 2 Carl Anderson CLA 2011-01-04 10:20:52 EST 
juny, from the build ID, it would appear that you are using Eclipse 3.6 and WTP 3.2.0.  Could you please try to reproduce this with Eclipse 3.6.1 and WTP 3.2.2 (which are the levels that were shipped in SR1)?  I was not able to reproduce this problem using SR1, so I believe it has already been fixed.
Comment 3 Carl Anderson CLA 2011-07-01 11:44:16 EDT 
Assigning this to Rob for initial investigation - this may have already been fixed.
Comment 4 Rob Stryker CLA 2011-07-05 08:05:24 EDT 
Assuming "simple web project" means "static web project", this is not fixed in maintenance from what I can see.
Comment 5 Rob Stryker CLA 2011-07-05 08:54:44 EDT 
Created attachment 199114 [details]
Make the WebModuleDependencyPageProvider apply to wst.web projects also

Make the WebModuleDependencyPageProvider apply to wst.web projects also
Comment 6 Rob Stryker CLA 2011-07-05 12:38:52 EDT 
Created attachment 199141 [details]
patch v2 to also ensure the property page closes properly

The fact that wst.web facet projects have no classpath caused the property page to not close on an "ok".  This is now fixed.
Comment 7 Rob Stryker CLA 2011-08-17 05:08:10 EDT 
Need patch approval for this to get into maintenance, and to avoid branching.
Comment 8 Chuck Bridgham CLA 2011-08-17 16:20:16 EDT 
looks good
Comment 9 Rob Stryker CLA 2011-08-22 02:39:51 EDT 
Committed and released to the relevant maps