Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332421 - [nls tooling] Hyperlink on properties file key doesn't work across projects
Summary: [nls tooling] Hyperlink on properties file key doesn't work across projects
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 05:32 EST by Markus Keller CLA
Modified: 2010-12-13 21:49 EST (History)
1 user (show)

See Also:

Attachments
fix (2.45 KB, patch)
2010-12-13 06:25 EST, Deepak Azad CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-12-13 05:32:15 EST 
N20101212-2000

- import org.eclipse.ui.ide and org.eclipse.ui.ide.application from CVS
- open this file:
/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/messages.properties
- Ctrl+Click on the key on line 952:
IDEApplication_workspaceCannotLockTitle=Workspace Cannot Be Locked

=> just beeps but doesn't open the reference in IDEApplication#checkInstanceLocation(Shell). Problem is probably that the reference is in another plug-in.
Comment 1 Markus Keller CLA 2010-12-13 05:32:23 EST 
Deepak, please have a look. I guess the search scope is confined to the declaring project. This is necessary for the textual search for performance reasons, but the Java search engine should be fast enough to do a full workspace search.
Comment 2 Deepak Azad CLA 2010-12-13 06:25:10 EST 
Created attachment 185046 [details]
fix

(In reply to comment #1)
> Deepak, please have a look. I guess the search scope is confined to the
> declaring project. This is necessary for the textual search for performance
> reasons, but the Java search engine should be fast enough to do a full
> workspace search.
Right, the patch should do the job.

I quickly tried this with my large dev workspace and I do not see any noticeable change in performance.
Comment 3 Markus Keller CLA 2010-12-13 11:34:30 EST 
Looks good, please release into the wild.
Comment 4 Deepak Azad CLA 2010-12-13 21:49:19 EST 
Fixed in HEAD.