Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332393 - Default encoding is removed in System Connection property page
Summary: Default encoding is removed in System Connection property page
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 332745
  Show dependency tree
 
Reported: 2010-12-12 09:19 EST by Noriaki Takatsu CLA
Modified: 2011-05-19 12:42 EDT (History)
1 user (show)

See Also:

Attachments
Fix for removing the default encoding erroneously (1.05 KB, patch)
2010-12-12 09:36 EST, Noriaki Takatsu CLA 		no flags Details | Diff
Fix for removing the default encoding erroneously (1.05 KB, patch)
2010-12-15 20:45 EST, Noriaki Takatsu CLA 		dmcknigh: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noriaki Takatsu CLA 2010-12-12 09:19:15 EST 
The following steps will remove the specified default encoding is removed erroneously in System Connection property page:

1. Create a new remote connection
2. Change the default encoding to other (e.g. IBM-1141) in System Connection
   property page before connecting to the remote system
3. Connect to the remote system
4. Display the default encoding again in System Connection property page 
   when the connection is active
5. Press OK key in System Connection property page.
   At this time, the encoding information was removed from the property file and 
   the content of the property file is:
     # RSE DOM Node
     00-name=EncodingPropertySet
     01-type=PropertySet
     03-attr.description=null
Comment 1 Noriaki Takatsu CLA 2010-12-12 09:36:27 EST 
Created attachment 185030 [details]
Fix for removing the default encoding erroneously
Comment 2 David McKnight CLA 2010-12-15 10:59:50 EST 
(In reply to comment #1)
> Created an attachment (id=185030) [details]
> Fix for removing the default encoding erroneously

That patch looks good.  Could you resubmit it with the updated copyright and a legal message.  Thanks.
Comment 3 Noriaki Takatsu CLA 2010-12-15 20:45:17 EST 
Created attachment 185283 [details]
Fix for removing the default encoding erroneously

I resubmit the patch with the following legal message:

IP records - Noriaki Takatsu, IBM Japan, takatsu@jp.ibm.com, 
             Office Address: 1623-14, Shimotsuruma, Yamato-shi, Kanagawa 
             Office phone:    81-46-215-5379

Legal Message:
 I, {Noriaki Takatsu}, declare that I developed the attached code from scratch, 
 without referencing any 3rd party materials except material licensed under 
 the EPL. 
 I am authorized by my employer to make this contribution under the EPL.
Comment 4 Noriaki Takatsu CLA 2010-12-15 21:01:08 EST 
The release level of the org.eclipse.rse.ui that RDz 8.0.1 uses is 3.1.102.v201010201412. 
Could you backport the fix to this release level ?
Comment 5 David McKnight CLA 2010-12-16 10:02:52 EST 
Comment on attachment 185283 [details]
Fix for removing the default encoding erroneously

Looks okay.  I'll update this with the copyright line.
Comment 6 David McKnight CLA 2010-12-16 10:10:26 EST 
I've committed the change to the HEAD stream and opened bug 332745 for the backport to RSE 3.2.x.
Comment 7 Martin Oberhuber CLA 2011-05-19 12:42:50 EDT 
Comment on attachment 185030 [details]
Fix for removing the default encoding erroneously

Obsoleted by later patch.