Community
Participate
Working Groups
Build Identifier: The XViewerCustomizeDialog currently has a number of sections for customizing different aspects of the XViewer (which columns are shown, column order, sorting, filtering, etc.). Some of these may not be applicable for a particular use case or implementors may want to add additional sections. Under the current design, existing sections cannot be left out and additional sections cannot be added. The dialog should be refactored to a more modular design. All existing functionality should be preserved. Existing code should continue to function in the same manner without changes. Additional APIs should be added to facilitate removal or addition of customization sections. Reproducible: Always
Created attachment 184982 [details] Proposed patch to allow This patch proposes changes to make the XViewerCustomizeDialog more customizable/extensible by the programmer using XViewer. I believe it faithfully maintains existing behavior. It maintains the existing appearance as much as is practical. p.s. It's been years since I've used CVS - so if you have trouble applying this patch, please let me know! Chris
Think I waited too long and am now having difficulty applying this patch. Can you sync up and create it again Chris?
I can try it, but I'm not sure how easy it will be to separate out these changes from the localization changes (at least, not without a lot of work). If I wait until after you have integrated the XViewerText classes, then I may be able to produce the patch without too much hassle. It will have additional progress I have made along these lines. The original patch ONLY handled refactoring the dialog for the customize UI to be extensible. I've made further changes to make the CustomizeData and CustomizeManager classes extensible as well - allowing us to add more data to be saved.
As you probably got emailed, I was able to apply the localization patch, but still can't get this patch to work. Any chance you can try to re-submit this one. Make sure you sync up with the latest in CVS first.
Don, I'm going to try the refactoring again. Unfortunately, you made a lot of changes to code that I had refactored into other classes, so no automated patch/merge tools have even been remotely successful. I'm going to have to start over with your latest code. Hopefully I'll have something in a few days.
Created attachment 186681 [details] Customize dialog refactoring - patch attempt #2 Don, I'm sending another patch (XViewerCustomizeDialogRefactor.patch) - hopefully this one will merge for you, as it was produced from the current sources (as of today). It is a structural refactoring that is not intended to alter the functionality at all. The UI remains the same with one exception - the Rename Columns button is moved to be closer to the column selection lists. I will provide a series of patches to make both the customization data and UI more extensible, but this much is a good start. TIA! Chris
Donald - I discovered that this latest patch reverses some of the translation changes I submitted earlier. I've already fixed those, in preparation for the next patch. It continues this refactoring by changing the UI slightly so each section in the dialog is expandable (via a twisty arrow) - to allow for more sections than will fit on the dialog. Would you prefer I submit that patch now - or wait until you've had a chance to integrate this one?
Created attachment 187472 [details] Patch attempt #3 Donald - I've tried again with a slightly different approach. The file (XViewer-refactor1.zip) contains a patch file and the other source files that need to be added. I created the patch from the org.eclipse.nebula.widgets.xviewer folder. I'm not sure if that matters when you apply the patch, since the patch file contains the full CVS file paths. I assume Eclipse can resolve that - IDEA does, and gives me the ability to modify the paths so they are applied to the right place. In addition to the patch file, I've included 5 new files (*.java) that go in "org.eclipse.swt.nebula\org.eclipse.nebula.widgets.xviewer\src\org\eclipse\nebula\widgets\xviewer\customize\dialog". I left those out of the patch since they seemed to be causing trouble. BTW, I started with a fresh checkout of the repository, but my old patch (from the 12th) applied just fine.
Trying to close old bugs. Where are we on this?
Cancelled due to unresponsiveness.
