Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332327 - [Compatibility] <dynamic> org.eclipse.ui.menus contributions to text editors appears to be ignored
Summary: [Compatibility] <dynamic> org.eclipse.ui.menus contributions to text editors ...
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 13:10 EST by Remy Suen CLA
Modified: 2011-05-16 14:51 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-12-10 13:10:32 EST 
The snippet below does not work on 4.1.

<extension point="org.eclipse.ui.menus">
  <menuContribution locationURI="popup:#TextEditorContext?after=additions">
    <dynamic
        class="b.items.CCIImpl"
        id="b.items.cci">
    </dynamic>
  </menuContribution>
</extension>
Comment 1 Remy Suen CLA 2010-12-10 13:21:16 EST 
Looks like it may be because MenuAdditionCacheEntry's addMenuChildren(*) method doesn't consider <dynamic> elements.
Comment 2 Remy Suen CLA 2010-12-10 13:48:41 EST 
Actually, based on bug 332240, it feels like you'll appear if you're nested within a <menu> but won't if you're not?
Comment 3 Remy Suen CLA 2010-12-10 14:52:57 EST 
See also bug 329439 for the targeted view case.
Comment 4 Remy Suen CLA 2011-05-16 14:51:33 EDT 
The snippet seems to be working now.