Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332306 - [Compatibility] 'New' wizard submenu is killed after installing Mylyn
Summary: [Compatibility] 'New' wizard submenu is killed after installing Mylyn
Status: CLOSED DUPLICATE of bug 340565
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321278
  Show dependency tree
 
Reported: 2010-12-10 09:07 EST by Remy Suen CLA
Modified: 2011-06-21 14:07 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot depicting the problem in question. (8.56 KB, image/png)
2010-12-10 09:07 EST, Remy Suen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-12-10 09:07:48 EST 
Created attachment 184955 [details]
Screenshot depicting the problem in question.

I20101209-0255

Now I only get one project menu item and a separator.
Comment 1 Remy Suen CLA 2010-12-10 09:11:58 EST 
The double update(boolean) calls to MenuManager seems to be the problem here. Changing update(false) to update(true) did not help.
Comment 2 Remy Suen CLA 2010-12-10 09:15:17 EST 
It seems to be the same general problem as the one uncovered in SwitchToWindowMenu. Since the contribution item is not deemed to be dirty, we don't think there is a need to "regenerate" the items and the existing ones gets disposed.
Comment 3 Remy Suen CLA 2010-12-10 10:20:24 EST 
This is enough to kill the submenu. It seems to me like the 'a.b.c' bit should be respected? Shouldn't I be targeting a view there anyway?

<extension point="org.eclipse.ui.menus">
  <menuContribution locationURI="popup:a.b.c?after=group.new">
    <menu
        id="new"
        label="New">
      <command
          commandId="org.eclipse.ui.window.nextView"
          style="push">
      </command>
    </menu>
  </menuContribution>
</extension>
Comment 4 Steffen Pingel CLA 2010-12-10 10:43:51 EST 
What extension in Mylyn is causing this?
Comment 5 Remy Suen CLA 2010-12-10 10:51:16 EST 
(In reply to comment #4)
> What extension in Mylyn is causing this?

The 'org.eclipse.mylyn.commons.team' bundle's plugin.xml contributes this snippet of XML.

I don't have any reason at the moment to believe that this is a problem on Mylyn's end though.
Comment 6 Paul Webster CLA 2010-12-13 10:17:08 EST 
(In reply to comment #3)
> This is enough to kill the submenu. It seems to me like the 'a.b.c' bit should
> be respected? Shouldn't I be targeting a view there anyway?
> 
> <extension point="org.eclipse.ui.menus">
>   <menuContribution locationURI="popup:a.b.c?after=group.new">
>     <menu
>         id="new"
>         label="New">
>       <command
>           commandId="org.eclipse.ui.window.nextView"
>           style="push">
>       </command>
>     </menu>
>   </menuContribution>
> </extension>

The 3.x behaviour is to merge all of the menus at a given level with the same ID.  So if there's already a "new" menu we should be applying our MMC to that existing one.

PW
Comment 7 Remy Suen CLA 2011-06-21 14:07:09 EDT 
Cannot reproduce with I20110620-1631 on Windows XP.

I'm quite positive this was fixed by the changes for bug 340565.

*** This bug has been marked as a duplicate of bug 340565 ***