Community
Participate
Working Groups
Build Identifier: M20101029-0800 If there is a tag inside comment, it gives error for comment not closed or the the regions are not properly constructed inside comments. <!-- <meta> --> gives error for comment not being closed. Reproducible: Always
Created attachment 184939 [details] Patc identifies the custom tags inside comment and parses them inside a container This patch adds the logic for parsing the custom tags inside the comment as a container. Currently one junit is failing, I am working on correcting it.
Created attachment 185153 [details] Patch to identify the custom tag inside comments with fixed junit test
Hi Sarika, Thanks for the patch. I'm having a problem though where when I reopen these files with <!-- <meta> --> in them, I still see the "Comment not closed." message. Also, SSE compiles against Java 1.4.2, which means that we can't make use of String#isEmpty(), which is used in your patch in the JSPTokenizer. We'll need to use String#length() == 0.
Created attachment 185288 [details] Patch to identify the custom tags inside comment with junit changes and file reopening problem resolved
Created attachment 185294 [details] Patch to identify the custom tags inside comment with junit changes and file reopening/String Empty problem resolved
Code checked in.
I actually backed out these changes, Sarika. I noticed, for example, if I had <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"> in a document under <head> and I used Ctrl+Shift+C to comment out the entire tag, I'd still get "Comment not closed" errors. Looks like there may be still something small missing.
Created attachment 186248 [details] Patch to identify the custom tags inside/outside comment with junit changes and file reopening problem resolved Hi Nick, Currently the Custom tag after the comment closure was also parsed, I have added the check not to do so.
Code checked in. Thanks for your persistence.
