Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332244 - Host not found error in XL C/C++ compiler property page
Summary: Host not found error in XL C/C++ compiler property page
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Remote Tools (show other bugs)
Version: 4.0.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 5.0   Edit
Assignee: Vivian Kong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 14:44 EST by Vivian Kong CLA
Modified: 2011-05-13 11:17 EDT (History)
4 users (show)

See Also:
recoskie: review+

Attachments
screenshot (50.74 KB, image/jpeg)
2010-12-09 14:44 EST, Vivian Kong CLA 		no flags Details
proposed patch for HEAD (15.36 KB, patch)
2011-05-11 17:33 EDT, Vivian Kong CLA 		vivkong: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivian Kong CLA 2010-12-09 14:44:05 EST 
Created attachment 184892 [details]
screenshot

Please see attached screenshot for the error.

RemoteXLCompilerPropertyPage uses the project location to figure out the remote host and create a path editor for the compiler path.  However it assumes the project location is a RSE location.
Comment 1 Vivian Kong CLA 2011-05-11 17:33:50 EDT 
Created attachment 195438 [details]
proposed patch for HEAD
Comment 2 Vivian Kong CLA 2011-05-11 17:39:01 EDT 
Greg, Chris, John, can you please review this patch when you have a moment?  The XLC compile property page is unusable for a remote tools connection without this fix.  This patch introduces an API breakage but I think it is the right thing to do (since we shouldn't assume a remote project is using a RSE connection) and I don't think anyone is using this API.

Also changed the name of the property page from "XL C/C++ Compiler" to "Remote XL C/C++ Compiler".

I appreciate your feedback.  Thanks.
Comment 3 Vivian Kong CLA 2011-05-11 22:39:35 EDT 
(In reply to comment #2)
> Also changed the name of the property page from "XL C/C++ Compiler" to "Remote
> XL C/C++ Compiler".

That actually shouldn't be changed.  Please ignore this change in the patch.
Comment 4 Chris Recoskie CLA 2011-05-12 09:38:26 EDT 
I didn't try it, but based on looking at the code it seems ok to me.
Comment 5 John Liu CLA 2011-05-13 09:55:06 EDT 
I applied the patch and did a brief test from my workspace, I didn't find any regression.
Comment 6 Vivian Kong CLA 2011-05-13 11:17:03 EDT 
Thanks for the reviews.  Fixed in HEAD.