Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332240 - [Compatibility] Invalid CompoundContributionItem contributions are showing up
Summary: [Compatibility] Invalid CompoundContributionItem contributions are showing up
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331440
  Show dependency tree
 
Reported: 2010-12-09 14:32 EST by Remy Suen CLA
Modified: 2011-05-16 14:22 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot depicting the problem in question. (8.17 KB, image/png)
2010-12-09 14:32 EST, Remy Suen CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-12-09 14:32:19 EST 
Created attachment 184889 [details]
Screenshot depicting the problem in question.

The XML definition appears to use a compound visibleWhen clause with an activeMenuSelection query, property testers, and adaptation checks.

http://dev.eclipse.org/viewcvs/viewvc.cgi/org.eclipse.tm.rse/plugins/org.eclipse.rse.useractions/plugin.xml?view=markup&revision=1.13&root=DSDP_Project
Comment 1 Martin Oberhuber CLA 2010-12-10 10:05:45 EST 
Xuan, can you comment on what the compile commands _should_ look like ?
Comment 2 Remy Suen CLA 2010-12-10 10:10:08 EST 
I should've been more specific. The left-hand side of the screenshot is 4.1 and the right-hand side is 3.7. So it seems like they're just not supposed to show up at all.

However, Xuan's confirmation of this would of course be helpful. :)
Comment 3 Paul Webster CLA 2010-12-13 10:15:03 EST 
We might not be applying the visibleWhen expression to our MMenus at all.

PW
Comment 4 Xuan Chen CLA 2010-12-14 12:12:09 EST 
The one on the right (3.7) is the right now.  Compile Command User Action menu should not appear for local shell.
Comment 5 Remy Suen CLA 2011-05-16 14:22:02 EDT 
No longer appears to be a problem with I20110515-0800. This may have been fixed by Paul's activeMenuSelection changes from bug 325390 comment 11.