Description Pascal Filion 2010-12-09 09:17:34 EST

Build Identifier: 2.2.0.v20101201-r8590

Enum.toString() should not be used in TypeHelperImpl.resolveEnumConstant() because it can result in not finding the constant. The objects need to be type casted to Enum<?> and then name() should be used. The code would become:

for (int i = 0; i < constants.length; i++) {
   Enum<?> enumConstant = (Enum<?) enumConstant;
   if (enumConstant.name().equals(constants[i])) {
      return constants[i];
   }
}


A user could have an enum like this:

public enum Color {
   RED("1"),
   BLUE("2");
   String color;
   Color(String color) {
      this.color = color;
   }
   public String toString() {
      return color;
   }
}

Doing constant.toString() on the constants will return "1" and "2" and Color.RED would not be resolved.

Reproducible: Didn't try

Steps to Reproduce:
1. Create an enum that overrides toString() and return anything that is not the name of the method (constant name).
2. Try to resolve the enum constant.
3. No enum constant will be found even though there is a match.