Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332191 - Expression text hover should use fallback if no parsing information is available
Summary: Expression text hover should use fallback if no parsing information is available
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 02:18 EST by Anton Leherbauer CLA
Modified: 2010-12-13 10:23 EST (History)
2 users (show)

See Also:

Attachments
Fix (16.05 KB, patch)
2010-12-13 05:00 EST, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details | Diff
Committed fix (21.72 KB, application/octet-stream)
2010-12-13 09:25 EST, Anton Leherbauer CLA 		aleherb+eclipse: iplog-
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2010-12-09 02:18:04 EST 
The default implementation of AbstractDebugTextHover.getExpressionText() return null if no parsing information is available.  In this case it should fall back to the text marked by the hoverRegion.
Comment 1 Anton Leherbauer CLA 2010-12-13 05:00:49 EST 
Created attachment 185045 [details]
Fix

This addresses also a few other issues:
- selected expression were not handled properly
- simple assignments were not filtered out
Comment 2 Anton Leherbauer CLA 2010-12-13 09:25:12 EST 
Created attachment 185060 [details]
Committed fix

This also takes into account an expression in code which is (incorrectly) marked as inactive.
Comment 3 Anton Leherbauer CLA 2010-12-13 09:27:15 EST 
Fixed in 7.0.2 and HEAD.