Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332190 - As a User I want to provide custom default web.xml outside of the 'org.eclipse.gemini.web.tomcat' bundle
Summary: As a User I want to provide custom default web.xml outside of the 'org.eclips...
Status: CLOSED FIXED
Alias: None
Product: Gemini.Web
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.2.0.M02   Edit
Assignee: Violeta Georgieva CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 02:13 EST by Violeta Georgieva CLA
Modified: 2011-02-07 03:14 EST (History)
2 users (show)

See Also:
milesg78: documentation+

Attachments
patch proposal (10.55 KB, patch)
2011-01-03 07:56 EST, Violeta Georgieva CLA 		glyn.normington: review+
Details | Diff
Documentation (9.36 KB, patch)
2011-02-03 10:09 EST, Violeta Georgieva CLA 		glyn.normington: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Violeta Georgieva CLA 2010-12-09 02:13:18 EST 
Build Identifier: 

Hi,

In the current Gemini.Web implementation the default web.xml is provided as web-embed.xml in 'org.eclipse.gemini.web.tomcat' bundle.
If I want to provide additional configuration in the default web.xml I want to have a possibility to provide such default web.xml outside this bundle e.g. this file to be read from a configuration directory.

Thanks in advance.
Regards
Violeta

Reproducible: Always
Comment 1 Glyn Normington CLA 2010-12-09 04:22:23 EST 
Thanks for logging the requirement. I think we've seen similar scenarios in the past, although there was not sufficient demand to implement the feature.
Comment 2 Violeta Georgieva CLA 2011-01-03 07:56:33 EST 
Created attachment 185953 [details]
patch proposal

Can you make a code review?

Thanks
Violeta
Comment 3 Glyn Normington CLA 2011-01-04 06:07:55 EST 
(In reply to comment #2)
> Created attachment 185953 [details]
> patch proposal
> 
> Can you make a code review?
> 
> Thanks
> Violeta

Looks good. Thanks.
Comment 4 Violeta Georgieva CLA 2011-01-06 02:37:17 EST 
Tested, committed and pushed.
Documentation is pending.
Comment 5 Violeta Georgieva CLA 2011-02-03 10:09:59 EST 
Created attachment 188242 [details]
Documentation

Hi,

Here is the documentation for default web.xml configuration.
Could you please review it.

Thanks in advance.
Regards
Violeta
Comment 6 Glyn Normington CLA 2011-02-04 04:38:19 EST 
(In reply to comment #5)
> Created attachment 188242 [details]
> Documentation
> 
> Hi,
> 
> Here is the documentation for default web.xml configuration.
> Could you please review it.
> 
> Thanks in advance.
> Regards
> Violeta

Done. Looks good.