Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332182 - o.e.c.expressions plugin missing .exsd files
Summary: o.e.c.expressions plugin missing .exsd files
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: platform-runtime-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 22:16 EST by Konstantin Komissarchik CLA
Modified: 2019-08-08 11:36 EDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (692 bytes, patch)
2010-12-08 22:21 EST, Konstantin Komissarchik CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2010-12-08 22:16:10 EST
The org.eclipse.core.expressions plugin isn't configured to package its .exsd files into the runtime bundle. They only get packaged into the source bundle. This is a problem because one of those schemas (expressionLanguage.exsd) is extensively imported into extension points throughout the Eclipse Ecosystem.

<include schemaLocation="schema://org.eclipse.core.expressions/schema/expressionLanguage.exsd"/>

The problem happens when you are working on the source of one of these importing plugins, but your target platform does not include Eclipse Platform source bundles. This causes PDE to flag your schemas with problems as it is unable to resolve schema import. Very annoying.

I think that there shouldn't be an assumption that everyone coding to API of org.eclipse.core.expressions bundle should have its source bundles in their target platform. The common practice is to package .exsd files in the runtime bundle. They are part of the bundle's API.

Will attach a simple patch to build.properties to fix this.
Comment 1 Konstantin Komissarchik CLA 2010-12-08 22:21:22 EST
Created attachment 184835 [details]
Patch v1

Attached patch moves the plugin's schema directory from source bundle to the runtime bundle. It would be great to have this considered for Indigo inclusion.
Comment 2 Markus Keller CLA 2010-12-09 09:51:11 EST
Sorry, I have to move this back to Platform/Runtime. During the ACL cleanup, I lost commit rights on org.eclipse.core.expressions, so I couldn't even commit this any more.

> I think that there shouldn't be an assumption that everyone coding to API of
> org.eclipse.core.expressions bundle should have its source bundles in their
> target platform. The common practice is to package .exsd files in the runtime
> bundle. They are part of the bundle's API.

See bug 139161 comment 3 about the "commonness" of packaging .exsd files in the binary bundle.

I guess the problem is that .exsd files are a mixture of
- API declaration (the schema, corresponds to Java .class files) and
- API documentation (corresponds to .java source files or generated Javadoc)

If we change some bundles to ship the schemas with the binary bundle, then we should do this in the whole SDK.
Comment 3 Konstantin Komissarchik CLA 2010-12-09 13:19:22 EST
IMHO the concerns over a little bit of extra space in runtime/binary bundles should take back seat to the pretty serious issue of being unable to code to many of platform's extension points unless platform source is also present.
Comment 4 Eclipse Genie CLA 2019-08-08 11:36:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.