Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332177 - Add support for new EventListenerHook to framework
Summary: Add support for new EventListenerHook to framework
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: BJ Hargrave CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 18:27 EST by BJ Hargrave CLA
Modified: 2010-12-10 11:34 EST (History)
1 user (show)

See Also:

Attachments
Patch to add support for EventListenerHooks (26.80 KB, patch)
2010-12-08 18:36 EST, BJ Hargrave CLA 		no flags Details | Diff
Updated patch for EventListenerHook support (28.83 KB, patch)
2010-12-10 11:25 EST, BJ Hargrave CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Hargrave CLA 2010-12-08 18:27:12 EST 
OSGi 4.3 is defining a new service hook. (See OSGi bug 1702.) This new EventListenerHook replaces the now deprecated EventHook.

The framework will continue to call the deprecated EventHook so existing EventHooks will continue to function. All registered EventHooks are called before the EventListenerHooks.
Comment 1 BJ Hargrave CLA 2010-12-08 18:36:46 EST 
Created attachment 184826 [details]
Patch to add support for EventListenerHooks

The patch adds support for calling EventListenerHooks. Several collection wrappers were written to avoid work until the hook requires it. This also required changes to the collection views on CopyOnWriteIdentityMap to support removal on the collections.

Tom, can you review? You will probably need to update the patch with api filter changes for the OSGi api changes.
Comment 2 BJ Hargrave CLA 2010-12-10 11:25:16 EST 
Created attachment 184963 [details]
Updated patch for EventListenerHook support

The updated patch includes correctly setting export version for o.o.f.hooks.service package to 1.1, .api_filters update for new OSGi class and changes to lazily allocate values map in ShrinkableValueCollectionMap.
Comment 3 BJ Hargrave CLA 2010-12-10 11:34:46 EST 
Released patch to HEAD.