Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332175 - Add extension for custom columns in the BaseMemoryStatisticsView
Summary: Add extension for custom columns in the BaseMemoryStatisticsView
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 17:31 EST by Mike Reid CLA
Modified: 2016-05-05 11:08 EDT (History)
2 users (show)

See Also:
jcayne: review+

Attachments
Patch (19.67 KB, patch)
2010-12-08 17:33 EST, Mike Reid CLA 		no flags Details | Diff
Conditional participation patch (10.46 KB, patch)
2010-12-21 11:13 EST, Mike Reid CLA 		no flags Details | Diff
Patch v3 (4.24 KB, patch)
2010-12-21 13:21 EST, Mike Reid CLA 		no flags Details | Diff
Patch v4 (10.50 KB, patch)
2010-12-21 13:50 EST, Mike Reid CLA 		no flags Details | Diff
Patch v4 + copyright notice (10.95 KB, patch)
2010-12-21 14:27 EST, Mike Reid CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2010-12-08 17:31:56 EST 
Allow consumers to extend the Object Allocations view with custom columns.
Comment 1 Mike Reid CLA 2010-12-08 17:33:16 EST 
Created attachment 184824 [details]
Patch

Attached patch which exposes extension point to define custom columns.
Comment 2 Mike Reid CLA 2010-12-08 17:35:33 EST 
Checked into HEAD.
Comment 3 Mike Reid CLA 2010-12-21 10:55:36 EST 
Reopening as it has become clear that a mechanism is needed to control whether or not a custom column is enabled for a given view/agentProxy.
Comment 4 Mike Reid CLA 2010-12-21 11:13:25 EST 
Created attachment 185648 [details]
Conditional participation patch

Attaching patch which enhances the extension point to allow a implementer to selective enable or disable the column based on the particulars of the page/view.
Comment 5 Mike Reid CLA 2010-12-21 13:21:34 EST 
Created attachment 185657 [details]
Patch v3

Corrected typo in conditional patch.
Comment 6 Mike Reid CLA 2010-12-21 13:45:32 EST 
Joel, can you review?
Comment 7 Mike Reid CLA 2010-12-21 13:50:34 EST 
Created attachment 185659 [details]
Patch v4
Comment 8 Joel Cayne CLA 2010-12-21 14:10:18 EST 
Patch looks good.

Please add the Copyright block to the new Interface.
Comment 9 Mike Reid CLA 2010-12-21 14:27:41 EST 
Created attachment 185664 [details]
Patch v4 + copyright notice

Updated patch to include copyright notice at top of ICustomColumnParticipation
Comment 10 Mike Reid CLA 2010-12-21 16:31:10 EST 
Requesting approval for this updated patch for 4.7.2.
Comment 11 Kathy Chan CLA 2010-12-21 16:37:04 EST 
Approved for 4.7.2.
Comment 12 Mike Reid CLA 2010-12-21 16:49:12 EST 
Checked into HEAD. Re-resolving.
Comment 13 Kathy Chan CLA 2011-02-11 13:45:42 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 14 Mike Reid CLA 2011-02-11 14:48:45 EST 
Verified in TPTP-4.7.2-201102102100.
Comment 15 Mike Reid CLA 2011-02-11 14:49:13 EST 
Closing.