Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332174 - RemoveComponentFromEnterpriseApplicationOperation should first try to remove based on the dependent object
Summary: RemoveComponentFromEnterpriseApplicationOperation should first try to remove ...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 17:18 EST by Aidyl Kareh CLA
Modified: 2010-12-10 10:27 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (6.14 KB, patch)
2010-12-08 17:23 EST, Aidyl Kareh CLA 		no flags Details | Diff
Proposed Patch - Updated (4.49 KB, patch)
2010-12-09 13:17 EST, Aidyl Kareh CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-12-08 17:18:50 EST 
Build Identifier: WTP 3.2.3

The RemoveComponentFromEnterpriseApplicationOperation class currently first tries to remove the module based on the dependent object. However, this is not done if the module is a binary file.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-12-08 17:23:19 EST 
Created attachment 184821 [details]
Proposed Patch

This patch updates the AddComponentToEnterpriseApplicationOp so that it sets the dependent object when the binary module is added and the RemoveComponentFromEnterpriseApplicationOperation so that it uses the dependent object when removing the binary module.
Comment 2 Aidyl Kareh CLA 2010-12-09 13:17:36 EST 
Created attachment 184879 [details]
Proposed Patch - Updated

Updated patch to reuse the same findReferencedComponent method in both classes.
Comment 3 Chuck Bridgham CLA 2010-12-09 13:45:55 EST 
approve
Comment 4 Jason Sholl CLA 2010-12-10 10:27:52 EST 
Code checked into 32M and HEAD for WTP 3.2.3 and 3.3