Community
Participate
Working Groups
Build Identifier: I20101205-2000 Since PDE uses its own p2 agent (introduced in bug 328928), a software site in a .target file which is not part of "Available Software Sites" cannot be edited. The "Edit content" dialog opens, but the dialog only shows software sites which are included in the available software sites (responsibility of the global p2 agent). Workaround: Manually add the site to the Available Software Sites. (With the consequences mentioned in bug 328928.) Reproducible: Always Steps to Reproduce: 1. Open a .target file which contains a software site that is not included in "Available Software Sites" 2. Select this Software Site and click edit 3. The Edit content (Edit Software Site) dialog opens, no site is selected 4. Only enabled sites from "Available Software Sites" can be selected
What used to happen and what do we want to happen? I'm not sure that anything about the site management particularly changed. Yes there will be fewer/different sites known to the PDE agent but even before it is still possible for one person to give another a .target that references unknown sites.
In 3.6.1, by opening the .target file with the target editor (and the target platform resolution which follows), the software sites specified in the target where automatically added to the "Available software sites", in case they were not already in it. As a consequence, these sites were also available in the "Edit content" dialog. With the changes .target files referencing unknown sites still work. It's only that these sites cannot be edited anymore. The p2 UI used for editing still uses the "Available software sites" as data source. So the user has to add the site manually there before editing.
(In reply to comment #2) > With the changes .target files referencing unknown sites still work. It's only > that these sites cannot be edited anymore. > The p2 UI used for editing still uses the "Available software sites" as data > source. So the user has to add the site manually there before editing. In the edit wizard we have to set up a UI context. I believe we currently use a default context which uses p2 default information (and the workspace p2 agent). I'm guessing that we didn't change the context to use the new agent. If that is all that is going on here, it should be an easy fix. You still won't be able to modify the known sites using the preference page though, so the link to it won't be helpful.
Yes, that is the problem.
Created attachment 184983 [details] partial removal of singleton references This patch is a first cut at removing references to the default ProvisioningUI et al. Remaining references to ProvisioningUI.getDefaultUI()... How to hook up RevertProfilePage and InstalledSoftware Paget to the UI or agent - Not sure where these are instantiated and if the ProvisioningUI can be injected there. ElementWrapping - Seems to mostly be needed around the Session to check enablement of repos ProvUIProvisioningListener - need the UI operation runner to check if the batch is over. PreloadingRepositoryHandler and subtypes - These command handlers need to find out what UI they are bound to. Not sure where they are created (via the registry?) but somehow they need the UI injected. Remaining references to ProvUIActivator.getDefault().getProvisioningUI() - There are a few around the UI model
Sigh. I put this patch and comment 5 on the wrong bug. It should be on bug 332314 (the number of which looks remarkably like this bug). Since the patch is for p2, I'll attach over there. Not sure how to obsolete this one so am leaving it for now...
Created attachment 184999 [details] partial removal of singleton references in pde and p2 ui I hope to work with the p2 UI folks to figure out the remaining issues in isolating the UI from the default agent. It could be that the PDE usecases do not need full isolation. Attached is an updated patch with the p2 UI changes so that we can play around with the PDE UI changes. This comes up and you can see that the set of repos in the target workflow is different from those in the IDE workflow. There are still likely gotchas etc.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This bug has been marked as stalebug a while ago without any further interaction. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
This bug was marked as stalebug a while ago. Marking as worksforme. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.
