Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332124 - [syntax highlighting] Semantic highlighting sometimes doesn't appear in class file editor
Summary: [syntax highlighting] Semantic highlighting sometimes doesn't appear in class...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 08:29 EST by Markus Keller CLA
Modified: 2011-01-25 10:35 EST (History)
1 user (show)

See Also:

Attachments
Fix (3.38 KB, patch)
2011-01-24 11:47 EST, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-12-08 08:29:47 EST 
I20101207-2000

Semantic highlighting sometimes doesn't appear in class file editor.

Steps:
- set an access and modification breakpoint on JavaEditor.fSemanticManager
- open a class file editor
=> suspended in JavaEditor.installSemanticHighlighting() and in ClassFileEditor.doSetInput(...).new Job() {...}.run(IProgressMonitor)

When the Job proceeds first, semantic highlighting are missing.

Furthermore, fSemanticManager and other fields are not volatile, so they aren't guaranteed to be up-to-date (this is not an issue any more if you know that the field will not be modified after the job has been scheduled).
Comment 1 Dani Megert CLA 2011-01-24 11:47:25 EST 
Created attachment 187445 [details]
Fix
Comment 2 Dani Megert CLA 2011-01-24 11:47:37 EST 
Fixed in HEAD.
Available in builds > I20110124-0916.
Comment 3 Dani Megert CLA 2011-01-25 10:35:46 EST 
Verified in I20110124-1800.