Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332101 - [console] FileLink requires line number > 1 when the spec indicates that -1 is acceptable
Summary: [console] FileLink requires line number > 1 when the spec indicates that -1 i...
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-07 23:12 EST by Samantha Chan CLA
Modified: 2020-05-24 12:05 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2010-12-07 23:12:48 EST
In the constructor of FileLink, fileLineNumber is an optional input.  Caller can input -1, and the link should still be opened.

In FileLink.linkActivated:

There is a check on fFileLineNumber > 0.  The link does not get activated when fFileLineNumber is < 0.
Comment 1 Robert Roth CLA 2016-04-21 08:35:21 EDT
I think that even though the file number is not a valid one, the file should still be opened, as probably that is why the link has been activated by the user.
Comment 2 Paul Pazderski CLA 2020-05-24 12:05:10 EDT
Cannot reproduce the issue. Tried an ant build which first prints the build file path. The link is a FileLink without line number (fFileLineNumber=-1) and activating the link does open the file in editor.