Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332054 - [prefs] Events fired for wrong node in EclipsePreferences
Summary: [prefs] Events fired for wrong node in EclipsePreferences
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: 3.6.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: equinox.compendium-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 207510
  Show dependency tree
 
Reported: 2010-12-07 12:08 EST by Szymon Ptaszkiewicz CLA
Modified: 2011-05-11 08:51 EDT (History)
4 users (show)

See Also:

Attachments
Patch showing the expected behaviour (982 bytes, patch)
2010-12-07 12:08 EST, Szymon Ptaszkiewicz CLA 		Szymon.Brandys: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2010-12-07 12:08:57 EST 
Created attachment 184734 [details]
Patch showing the expected behaviour

In org.eclipse.core.internal.preferences.EclipsePreferences.convertFromProperties(EclipsePreferences, Properties, boolean) listeners of wrong node are notified about new key-value pair being added. If we are calling childNode.internalPut(key, value) then we should be calling firePreferenceEvent for 'childNode' not for 'node'. Attached patch shows the expected behaviour.
Comment 1 DJ Houghton CLA 2011-03-24 17:17:57 EDT 
Fixed in HEAD.