Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332040 - [zOS] JPIBootLoader fails to extract jpi_home parameter when multiple profiler options specified
Summary: [zOS] JPIBootLoader fails to extract jpi_home parameter when multiple profile...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC other
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-07 11:01 EST by Mike Reid CLA
Modified: 2016-05-05 11:08 EDT (History)
1 user (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2010-12-07 14:20 EST, Mike Reid CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2010-12-07 11:01:50 EST 
The -agentpath implementation for zOS requires a helper parameter be given to the profiler so that it can locate dependent libraries. However the code which extracts this parameter can be fooled if there are multiple options specified to the chosen profiler, e.g.:

 -agentpath:/../libJPIBootLoader.so=JPIAgent:server=...,jpi_home=...;HeapProf:allocsites=enabled,heapinstancedata=enabled
 
When scanning for the end of the 'jpi_home' parameter, the existing code can be fooled by the comma just before the 'heapinstancedata' parameter. This causes a failure to intialize the profiler.
Comment 1 Mike Reid CLA 2010-12-07 14:20:39 EST 
Created attachment 184746 [details]
Patch

Patch attached to robustify the jpi_home extraction.
Comment 2 Mike Reid CLA 2010-12-07 14:21:39 EST 
Checked into HEAD.
Comment 3 Kathy Chan CLA 2011-02-11 13:45:37 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 4 Mike Reid CLA 2011-02-11 14:31:29 EST 
Verified in TPTP-4.7.2-201102102100.
Comment 5 Mike Reid CLA 2011-02-11 14:49:52 EST 
Closing.