Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 332032 - Errors in generating model code for Probekit model
Summary: Errors in generating model code for Probekit model
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: post472
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-07 10:28 EST by Joel Cayne CLA
Modified: 2016-05-05 10:59 EDT (History)
4 users (show)

See Also:

Attachments
patch (10.17 KB, patch)
2010-12-14 17:39 EST, Paul Klicnik CLA 		no flags Details | Diff
patch (22.83 KB, patch)
2010-12-15 11:34 EST, Paul Klicnik CLA 		no flags Details | Diff
updated patch (23.45 KB, patch)
2011-01-21 10:19 EST, Paul Klicnik CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2010-12-07 10:28:19 EST 
Following the steps outlined in http://eclipse.org/tptp/platform/documents/resources/models/TPTP_Model_Generation.html#3.0, Probekit model validation reports no errors.

When generating the model code, the Classes DataType and ProbekitFactoryImpl is different from the files in CVS. There is a new attribute and Class cast errors.
Comment 1 Jonathan West CLA 2010-12-07 11:32:45 EST 
Paul, can you take a look?
Comment 2 Kathy Chan CLA 2010-12-14 11:51:05 EST 
Paul, please take a look and contact Joel if you have problem reproducing the error.
Comment 3 Paul Klicnik CLA 2010-12-14 17:39:56 EST 
Created attachment 185183 [details]
patch

Attaching patch. Note that this only adds the numPreviousUnits attribute to the model. There is still an additional issue which was introduced when the model generated code was bumped up to 1.5
Comment 4 Paul Klicnik CLA 2010-12-15 11:34:02 EST 
Created attachment 185241 [details]
patch
Comment 5 Kathy Chan CLA 2011-01-04 16:12:09 EST 
Does this latest patch address the issue in comment #3?  Is this ready to be checked in?
Comment 6 Paul Klicnik CLA 2011-01-21 10:19:04 EST 
Created attachment 187290 [details]
updated patch

Attaching final patch. The following changes were made to the model:

- Add the 'numPreviousUnits' DataType to the model and assign it value of 14
- Change the DataTypeObject type from org.eclipse.emf.common.util.AbstractEnumerator to org.eclipse.emf.common.util.Enumerator
- Change the FragmentTypeObject type from org.eclipse.emf.common.util.AbstractEnumerator to org.eclipse.emf.common.util.Enumerator
Comment 7 Kathy Chan CLA 2011-01-21 15:02:57 EST 
Paul,

Joel / Paul K. indicated that you made some change to the Probekit model before and would like to have your opinion on the proposed change.

Since it's too late to make the model change now, deferring to future to make the change post TPTP 4.7.2.
Comment 8 Paul Slauenwhite CLA 2011-01-23 11:44:30 EST 
(In reply to comment #7)
> Paul,
> 
> Joel / Paul K. indicated that you made some change to the Probekit model before
> and would like to have your opinion on the proposed change.

Kathy, I am not comfortable commenting on the actual fix given that I have not worked with the Probekit model for 3 - 4 years. That said, a couple comments on the patch:

-The documentation value should formatted for proper HTML rendering.
-Update the copyright year.
-Ctrl-O (Java editor in Eclipse) the use of import org.eclipse.hyades.models.internal.probekit.*.
Comment 9 Kathy Chan CLA 2011-03-25 16:13:29 EDT 
No plan to fix.
Comment 10 Joel Cayne CLA 2011-03-28 12:05:52 EDT 
Closing.