Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331977 - Trailing space in URI causes connection problems and restart of Eclipse
Summary: Trailing space in URI causes connection problems and restart of Eclipse
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 0.11-M1   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-07 01:40 EST by Johan Natt och Dag CLA
Modified: 2011-01-19 03:46 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Natt och Dag CLA 2010-12-07 01:40:27 EST
A URI that, for example, is copied from the web (e.g., from ProjectLocker) may include a trailing space.

This may causes the following:

a) If user has not tried to connect to the git server before, EGit keeps asking for password (not passphrase). A restart of Eclipse is REQUIRED before trying again (now without the trailing space in the URI).

b) If the user has connected to the site before, Egit replies with an error message "Arguments to command look dangerous". In this case restart is NOT required.

This problem causes lot of headache and it can be very hard for the end user to discover and find the correct resolution.

I suggest that EGit at least warns about trailing characters that do not belong in the URI. Often trimming is made to handle this, but a warning could suffice. However, that a restart is required may call for other measures.
Comment 1 Johan Natt och Dag CLA 2010-12-07 01:42:00 EST
EGit version is actually 0.9.1, but it is not available in the drop-down list in Bugzilla.
Comment 2 Mathias Kinzler CLA 2010-12-30 05:25:56 EST
Fix proposed at http://egit.eclipse.org/r/#change,2190
Comment 3 Chris Aniszczyk CLA 2011-01-19 03:46:19 EST
Fixed with a6d127ae1a588186525dbaaba6f7388ea8cfa048.