Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331954 - Polish Use Scan Feature II
Summary: Polish Use Scan Feature II
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 331811
Blocks: 333658
  Show dependency tree
 
Reported: 2010-12-06 16:06 EST by Michael Rennie CLA
Modified: 2011-01-26 12:49 EST (History)
3 users (show)

See Also:
ankur_sharma: review+

Attachments
Fix (13.89 KB, patch)
2011-01-05 16:32 EST, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-12-06 16:06:44 EST 
+++ This bug was initially created as a clone of Bug #331811 +++

Opening this clone for the remaining identified polish work for M5

4) Preference page should have a link to the error level page.

5) Error levels should not be ignore by default.  Currently the user sets up the scan on the preference page, it asks you if you want to build and you say "great, go for it".  No errors are reported, which is perfect until you realize that there are no errors being reported period.

6) Is there any value to letting the user change the cache size?  As a user I have know idea what a reasonable value it and whether it would be beneficial for me to change it.  No need to give the user an advanced option unless there is a definite need by some users.
Comment 1 Curtis Windatt CLA 2011-01-05 16:32:30 EST 
Created attachment 186130 [details]
Fix
Comment 2 Curtis Windatt CLA 2011-01-05 16:36:36 EST 
Fixed in HEAD (see the patch for my changes).

Ankur, please verify.
Comment 3 Ankur Sharma CLA 2011-01-06 05:40:55 EST 
+1. Looks good.

However since the cache size is not configurable anymore, try test it with a heavy usescan and see if we need a better default value.
Comment 4 Curtis Windatt CLA 2011-01-26 12:49:00 EST 
Verified in I20110126-0800