Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331952 - Annotations context menu has been registered globally
Summary: Annotations context menu has been registered globally
Status: VERIFIED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 15:49 EST by Navid Mehregani CLA
Modified: 2010-12-21 13:25 EST (History)
1 user (show)

See Also:

Attachments
331952 patch (19.08 KB, patch)
2010-12-16 00:42 EST, Anton Salnik CLA 		no flags Details | Diff
331952 empty selection patch (1.85 KB, patch)
2010-12-21 10:40 EST, Anton Salnik CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-12-06 15:49:17 EST 
Build Identifier: 

At the moment when you right click on anything in TS explorer, the annotation context menu is displayed.  These context menu actions should only be displayed on items that you can add an annotation to.

As an example, try right clicking on a Java project in TS explorer.  Notice that annotation context menu actions are displayed.

Reproducible: Always
Comment 1 Anton Salnik CLA 2010-12-16 00:42:41 EST 
Created attachment 185290 [details]
331952 patch

Patch attached.
Comment 2 Yuri Strot CLA 2010-12-17 08:21:22 EST 
Patch from Anton applied.
Comment 3 Navid Mehregani CLA 2010-12-21 09:52:48 EST 
I'm still seeing this issue.  Launched in a new workspace > Right click in problems view (without selecting anything) > Notice annotation contribution is there.
Comment 4 Anton Salnik CLA 2010-12-21 10:40:34 EST 
Created attachment 185642 [details]
331952 empty selection patch

Empty selection case was missed. Patch attached.
Comment 5 Yuri Strot CLA 2010-12-21 10:47:53 EST 
Applied patch with empty selection handling.
Comment 6 Navid Mehregani CLA 2010-12-21 13:25:00 EST 
Looks good. Thanks!