Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331899 - EPartService needs to protect its DI code
Summary: EPartService needs to protect its DI code
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.1 M5   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 09:17 EST by Remy Suen CLA
Modified: 2011-01-26 09:21 EST (History)
0 users

See Also:


Attachments
EPartService patch v1 (2.66 KB, patch)
2010-12-06 09:33 EST, Remy Suen CLA
no flags Details | Diff
EPartService patch v2 (997 bytes, patch)
2010-12-10 14:44 EST, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-12-06 09:17:43 EST
Client code can be hazardous so we should protect ourselves from any potential runtime exceptions.
Comment 1 Remy Suen CLA 2010-12-06 09:33:09 EST
Created attachment 184602 [details]
EPartService patch v1
Comment 2 Remy Suen CLA 2010-12-06 09:34:39 EST
Patch released to CVS HEAD.
Comment 3 Remy Suen CLA 2010-12-10 14:44:10 EST
I'm calling the wrong method so that exception is not actually getting logged properly.
Comment 4 Remy Suen CLA 2010-12-10 14:44:41 EST
Created attachment 184986 [details]
EPartService patch v2
Comment 5 Remy Suen CLA 2011-01-04 13:14:00 EST
(In reply to comment #4)
> Created attachment 184986 [details]
> EPartService patch v2

Fix released to CVS HEAD.
Comment 6 Remy Suen CLA 2011-01-26 09:21:11 EST
Verified by source inspection with I20110125-2200 on Windows XP that the code changes are there.