Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331807 - NPE makes API Use Scan Pref Page unusable
Summary: NPE makes API Use Scan Pref Page unusable
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 14:01 EST by Curtis Windatt CLA
Modified: 2010-12-07 13:56 EST (History)
2 users (show)

See Also:
ankur_sharma: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-12-03 14:01:10 EST 
java.lang.NullPointerException
at org.eclipse.pde.api.tools.ui.internal.preferences.ApiUseScanPreferencePage.hasLocationsChanges(ApiUseScanPreferencePage.java:456)
at org.eclipse.pde.api.tools.ui.internal.preferences.ApiUseScanPreferencePage.applyChanges(ApiUseScanPreferencePage.java:433)
at org.eclipse.pde.api.tools.ui.internal.preferences.ApiUseScanPreferencePage.performApply(ApiUseScanPreferencePage.java:366)
at org.eclipse.jface.preference.PreferencePage$2.widgetSelected(PreferencePage.java:281)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
Comment 1 Curtis Windatt CLA 2010-12-03 14:03:09 EST 
I have a fix for the NPE, but then I get the following.  I will work on an additional fix.

org.eclipse.core.runtime.AssertionFailedException: null argument:
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)
	at org.eclipse.pde.api.tools.internal.util.Util.getBuildJob(Util.java:532)
	at org.eclipse.pde.api.tools.ui.internal.preferences.ApiUseScanPreferencePage.applyChanges(ApiUseScanPreferencePage.java:436)
	at org.eclipse.pde.api.tools.ui.internal.preferences.ApiUseScanPreferencePage.performApply(ApiUseScanPreferencePage.java:366)
	at org.eclipse.jface.preference.PreferencePage$2.widgetSelected(PreferencePage.java:281)
Comment 2 Curtis Windatt CLA 2010-12-03 14:29:29 EST 
Fixed in HEAD.  Ankur, please verify.
Comment 3 Curtis Windatt CLA 2010-12-03 14:29:40 EST 
Fixed
Comment 4 Curtis Windatt CLA 2010-12-03 14:30:58 EST 
For the NPE you just need a clean workspace.  Anyone who tried using the version in HEAD for the first time wouldn't be able to!

For the second error, you need to have no projects in your workspace that have api tooling enabled.
Comment 5 Ankur Sharma CLA 2010-12-04 17:16:29 EST 
+1
Comment 6 Curtis Windatt CLA 2010-12-07 13:56:12 EST 
Verified in I20101206-1800