Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331788 - NLS: Severities for Code Analysis Problem Preferences not externalized for translation
Summary: NLS: Severities for Code Analysis Problem Preferences not externalized for tr...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Project Inbox CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 12:21 EST by Kit Lo CLA
Modified: 2011-05-24 11:23 EDT (History)
4 users (show)

See Also:

Attachments
screen capture (160.14 KB, image/pjpeg)
2010-12-03 12:21 EST, Kit Lo CLA 		no flags Details
proposed patch for HEAD (8.84 KB, patch)
2011-05-06 15:22 EDT, Vivian Kong CLA 		vivkong: iplog-
vivkong: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2010-12-03 12:21:34 EST 
Created attachment 184484 [details]
screen capture

Build: 8.0.0-I201011050851

Severities ("Info", "Warning", "Error") for Code Analysis Problem Preferences not externalized for translation.
Comment 1 Kit Lo CLA 2011-04-06 09:03:40 EDT 
Problem still exists in 8.0.0-I201103111317 build.
Comment 2 Vivian Kong CLA 2011-05-06 15:22:02 EDT 
Created attachment 194979 [details]
proposed patch for HEAD

Hi Alena, can you please review the attached patch?  I hope I have replaced all the toString() to toTranslatableString() but I just want to be sure.  Thanks.
Comment 3 Elena Laskavaia CLA 2011-05-10 10:50:59 EDT 
I need to look at it more, please don't commit yet. These values used in profiles, we should not attempt to save translated value in there. Mapping between translated values and original values can be tricky
Comment 4 Vivian Kong CLA 2011-05-19 11:04:21 EDT 
(In reply to comment #3)
> I need to look at it more, please don't commit yet. These values used in
> profiles, we should not attempt to save translated value in there. Mapping
> between translated values and original values can be tricky

Hi Alena, do you think we can get this fixed in RC2?
Comment 5 Elena Laskavaia CLA 2011-05-21 12:07:39 EDT 
+1
please commit the patch (I lost my commit rights because of legal issues)
Comment 6 Vivian Kong CLA 2011-05-24 10:44:37 EDT 
(In reply to comment #5)
> +1
> please commit the patch (I lost my commit rights because of legal issues)

Thanks for your review.

Fixed in HEAD