Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331699 - EditorsView's EditorsContentProvider can be replaced by ArrayContentProvider
Summary: EditorsView's EditorsContentProvider can be replaced by ArrayContentProvider
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-02 12:20 EST by Remy Suen CLA
Modified: 2010-12-14 05:31 EST (History)
0 users

See Also:

Attachments
Fix v01 (2.27 KB, patch)
2010-12-03 11:49 EST, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (5.27 KB, application/octet-stream)
2010-12-03 11:49 EST, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-12-02 12:20:09 EST 
The content provider just returns the array as-is. The ArrayContentProvider from JFace can be used instead, see ArrayContentProvider.getInstance().
Comment 1 Tomasz Zarna CLA 2010-12-03 11:49:06 EST 
Yup, makes sense to me. How do you find these things Remy? ;)
Comment 2 Tomasz Zarna CLA 2010-12-03 11:49:25 EST 
Created attachment 184479 [details]
Fix v01
Comment 3 Tomasz Zarna CLA 2010-12-03 11:49:27 EST 
Created attachment 184480 [details]
mylyn/context/zip
Comment 4 Remy Suen CLA 2010-12-03 12:01:44 EST 
(In reply to comment #1)
> How do you find these things Remy? ;)

When I open random views for testing 4.x, I sometimes like to check the implementation for suspicious coding patterns that may cause problems in the future (even if the view opens up properly "today").
Comment 5 Tomasz Zarna CLA 2010-12-14 05:31:33 EST 
Fixed in HEAD, available in builds >=I20101214-0800. Thanks Remy.