This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 331690 - [Trim] [Min/Max] Update our EventBroker usage in add-ons
Summary: [Trim] [Min/Max] Update our EventBroker usage in add-ons
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Eric Moffatt CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-02 11:25 EST by Paul Webster CLA
Modified: 2013-10-29 10:46 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-12-02 11:25:05 EST 
Our add-ons currently subscribe handlers to one or more topics, and are effected by Bug 331645 ex:

broker.subscribe(
UIEvents.buildTopic(UIEvents.KeyBinding.TOPIC, UIEvents.KeyBinding.PARAMETERS),
additionHandler);

The UIEvents constants can be re-structured so UIEvents.buildTopic(*) is no longer needed, and then we can use the "new way" of subscribing to events:

@Inject @Optional
public void event(@EventTopic(TOPIC) Object data) {
}

PW
Comment 1 Lars Vogel CLA 2013-03-08 08:07:58 EST 
Any plans to convert the usage of EventBroker to DI for Eclipse 4.3? I could try to provide patches if you would consider them.
Comment 2 Paul Webster CLA 2013-03-08 08:14:39 EST 
Hi Lars,

Pick an Addon and push something to Gerrit and we'll get it reviewed.

PW
Comment 3 Lars Vogel CLA 2013-09-06 10:32:34 EDT 
Gerrit review for the MinMax-Addon: https://git.eclipse.org/r/16191
Comment 4 Paul Webster CLA 2013-09-09 15:39:10 EDT 
Eric, could you please review https://git.eclipse.org/r/16191

PW
Comment 6 Eric Moffatt CLA 2013-10-29 10:46:47 EDT 
Verified (visually) in 4.4.0.I20131028-2000.