Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331687 - Proposal replacement length not properly adjusted
Summary: Proposal replacement length not properly adjusted
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-02 11:03 EST by Nick Sandonato CLA
Modified: 2010-12-03 14:14 EST (History)
0 users

See Also:
thatnitind: review+

Attachments
patch (2.31 KB, patch)
2010-12-02 11:08 EST, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-12-02 11:03:25 EST 
In particular this seems to happen when the original replacement length of the proposal is greater than 0. To see this happen, in an HTML file start with:

<div dir="|"

At the |, invoke content assist and type 'l', then pick "ltr" from the proposals. At this point, you'll end up with <div dir="ltr""
Comment 1 Nick Sandonato CLA 2010-12-02 11:08:38 EST 
Created attachment 184364 [details]
patch

Simplify the logic in the validate() method to adjust the replacement length by the document event changes.
Comment 2 Nick Sandonato CLA 2010-12-03 14:14:53 EST 
Code changes checked in.