Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331626 - [api] attribute editors should have a tooltip
Summary: [api] attribute editors should have a tooltip
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331154
  Show dependency tree
 
Reported: 2010-12-01 20:43 EST by Benjamin Muskalla CLA
Modified: 2011-02-02 01:48 EST (History)
2 users (show)

See Also:

Attachments
patch V1 (16.74 KB, patch)
2010-12-04 12:58 EST, Frank Becker CLA 		eclipse: review?
Details | Diff
mylyn/context/zip (9.43 KB, application/octet-stream)
2010-12-04 12:58 EST, Frank Becker CLA 		no flags Details
patch V2 (16.14 KB, patch)
2010-12-10 17:30 EST, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (12.09 KB, application/octet-stream)
2010-12-10 17:30 EST, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-12-01 20:43:02 EST 
The label of attribute editors should support an additional description as tooltip. Could be handled via the metadata.

metaData.setLabel("a field");
metaData.setDescription("a field to enter something");
Comment 1 Steffen Pingel CLA 2010-12-02 03:00:47 EST 
+1 This looks similar to bug 331154.
Comment 2 Frank Becker CLA 2010-12-02 14:36:14 EST 
(In reply to comment #1)
> +1 This looks similar to bug 331154.

Yes, but bug#331154 only add this for the TaskOperation. Should I use this bug for adding this to the other Attribute Editors?
Comment 3 Frank Becker CLA 2010-12-04 12:58:09 EST 
Created attachment 184538 [details]
patch V1

Steffen,

please verify my implementation.

Thanks!
Comment 4 Frank Becker CLA 2010-12-04 12:58:13 EST 
Created attachment 184539 [details]
mylyn/context/zip
Comment 5 Benjamin Muskalla CLA 2010-12-07 08:40:31 EST 
I wonder if it would make sense to add a getTooltip or getDescription to AbstractAttributeEditor to not go trough the whole taskattribute,metadata,metatooltip chain like it is already present for the label attribute.
Comment 6 Steffen Pingel CLA 2010-12-10 15:32:13 EST 
Yes, please add a getDescription() method that encapsulates retrieval of the tooltip. Otherwise, please feel free to apply the patch.
Comment 7 Frank Becker CLA 2010-12-10 15:43:43 EST 
(In reply to comment #6)
> Yes, please add a getDescription() method that encapsulates retrieval of the
> tooltip. Otherwise, please feel free to apply the patch.

Yes I commit this soon, but for TaskEditorActionPart we need to use taskattribute,metadata,metatooltip chain
Comment 8 Steffen Pingel CLA 2010-12-10 16:32:27 EST 
(In reply to comment #7)
> Yes I commit this soon, but for TaskEditorActionPart we need to use
> taskattribute,metadata,metatooltip chain

Sounds fine.
Comment 9 Frank Becker CLA 2010-12-10 17:30:50 EST 
Created attachment 185005 [details]
patch V2

commited patch
Comment 10 Frank Becker CLA 2010-12-10 17:30:53 EST 
Created attachment 185006 [details]
mylyn/context/zip
Comment 11 Steffen Pingel CLA 2010-12-10 18:15:32 EST 
What is the reason for making AbstractAttributeEditor.setDescription() private?
Comment 12 Frank Becker CLA 2010-12-11 02:27:13 EST 
(In reply to comment #11)
> What is the reason for making AbstractAttributeEditor.setDescription() private?

Actual we need the set only in the Constructor. Should I change this to public?
Comment 13 Steffen Pingel CLA 2011-01-04 14:36:06 EST 
(In reply to comment #12)
> (In reply to comment #11)
> > What is the reason for making AbstractAttributeEditor.setDescription()
> private?
> 
> Actual we need the set only in the Constructor. Should I change this to public?

Yes, please.
Comment 14 Steffen Pingel CLA 2011-02-02 01:48:44 EST 
Looks like we are done here.