Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331613 - 'Deployment Assembly' properties page placing binary module files inside EAR's library directory
Summary: 'Deployment Assembly' properties page placing binary module files inside EAR'...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 16:49 EST by Aidyl Kareh CLA
Modified: 2010-12-01 19:50 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (5.39 KB, patch)
2010-12-01 16:56 EST, Aidyl Kareh CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-12-01 16:49:51 EST 
Build Identifier: WTP 3.2.3

Create an EAR project, open the 'Deployment Assembly' properties page and add an external binary module file (e.g. 'TestWeb.war') ('Add...' -> 'Archives from File System'). It will assemble the binary module file into the EAR's lib folder and does not update the application.xml.  The same problem also exists when assembling from an archive in the workspace or variable. The default behavior for EJB JAR files, Application Client JAR files, WARs and RARs should be to place them in the root of the EAR and not in the lib folder.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-12-01 16:56:59 EST 
Created attachment 184311 [details]
Proposed Patch

Code overrides the handleAddDirective() method to add a quick peek to the binary files that are added so that if they are identified as EJB, Application Client, Web or Connector it sets their deploy path to the root of the EAR.
Comment 2 Chuck Bridgham CLA 2010-12-01 17:10:33 EST 
approve
Comment 3 Carl Anderson CLA 2010-12-01 19:50:40 EST 
Committed to R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3