Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331611 - WebXmlUpdater - multiple method calls fail to update model
Summary: WebXmlUpdater - multiple method calls fail to update model
Status: CLOSED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2.3   Edit
Assignee: Ian Trimble CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 323185
Blocks:
  Show dependency tree
 
Reported: 2010-12-01 16:26 EST by Ian Trimble CLA
Modified: 2010-12-06 11:52 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Trimble CLA 2010-12-01 16:26:07 EST 
When multiple WebXmlUpdater methods are called sequentially, only the first method will succeed.

For example (where "updater" is an instance of WebXmlUpdater), this succeeds:

    updater.addServlet("Foo", "org.foo.Foo", "1");

but this successfully adds only the servlet and not the context parameter:

    updater.addServlet("Foo", "org.foo.Foo", "1");
    updater.addContextParam("Bar", "Hmm", "Stuff");

This causes two failing tests in the core tests suite:
 - testAddContextParam, and
 - testAddServletMapping
Comment 1 Raghunathan Srinivasan CLA 2010-12-01 17:00:30 EST 
Please review if this is caused by the fix for bug 323185
Comment 2 Ian Trimble CLA 2010-12-02 12:20:11 EST 
(In reply to comment #1)
> Please review if this is caused by the fix for bug 323185

If I reverse the patch for bug 323185, things work correctly.
Comment 3 Dimitar Giormov CLA 2010-12-06 02:52:07 EST 
Hi the dependent bug was fixed. I have run your tests and they passed.
Hopefully you can close the issue now.
Comment 4 Ian Trimble CLA 2010-12-06 11:52:38 EST 
Fix for blocking bug has corrected the problem.