Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331596 - EAR shouldn't be allowed to be dragged/dropped into itself or another EAR
Summary: EAR shouldn't be allowed to be dragged/dropped into itself or another EAR
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-01 14:45 EST by Aidyl Kareh CLA
Modified: 2010-12-01 19:45 EST (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (3.79 KB, patch)
2010-12-01 14:55 EST, Aidyl Kareh CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-12-01 14:45:30 EST 
Build Identifier: WTP 3.2.3

In the Project Explorer view, a user can drag an EAR into its own deployment descriptor node or the project node itself. This will cause an entry for the EAR to be added into the Deployment Assembly, which shouldn't be allowed.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-12-01 14:55:04 EST 
Created attachment 184297 [details]
Proposed Patch

Patch fixes a bug in the Drop Assistant's validateDrop() logic where it was finding that this was not a valid scenario but was incorrectly overwriting the status and returning that it was valid.
Comment 2 Chuck Bridgham CLA 2010-12-01 17:08:33 EST 
approve
Comment 3 Carl Anderson CLA 2010-12-01 19:45:23 EST 
Committed to R3_2_maintenance and HEAD for WTP 3.2.3 and WTP 3.3