Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 331590 - ModelManager overly-synchronized for getting referenceCounts
Summary: ModelManager overly-synchronized for getting referenceCounts
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.2.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-12-01 14:17 EST by Nick Sandonato CLA
Modified: 2010-12-03 14:16 EST (History)
0 users

See Also:
thatnitind: review+

Attachments
patch (1.96 KB, patch)
2010-12-01 14:19 EST, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-12-01 14:17:25 EST 
The ModelManagerImpl is overly-synchronized in a few places when reading reference counts. This has the potential to cause deadlocks.
Comment 1 Nick Sandonato CLA 2010-12-01 14:19:15 EST 
Created attachment 184290 [details]
patch

Patch to avoid taking the SYNC lock, which is meant to guard the managed objects map.
Comment 2 Nick Sandonato CLA 2010-12-03 14:16:43 EST 
Changes released.